Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logout button #19

Closed
jhgoebbert opened this issue Apr 26, 2019 · 12 comments · Fixed by #20
Closed

Logout button #19

jhgoebbert opened this issue Apr 26, 2019 · 12 comments · Fixed by #20
Labels
enhancement New feature or request ext:logout Log Out Extension new-extension Idea for a new extension

Comments

@jhgoebbert
Copy link

Hello,

I like your plugin. Perhaps it could make the logout-button of the jupyterlab/hub-extension more visible (?)
jupyterhub/jupyterlab-hub#87

Best regards,
Jens Henrik

@jhgoebbert
Copy link
Author

There might be some work going on here for JupyterLab 1.0:
jupyterlab/jupyterlab#6087

@jtpio
Copy link
Member

jtpio commented Apr 27, 2019

Thanks @jhgoebbert, that's a good idea for a new jupyterlab-logout-button extension.

@jtpio jtpio added enhancement New feature or request new-extension Idea for a new extension labels Apr 27, 2019
@jtpio
Copy link
Member

jtpio commented May 7, 2019

@jhgoebbert PR https://github.com/jtpio/jupyterlab-topbar/pull/20 adds a logout button to the top area.

Is that what you had in mind? (feedback welcome!)

@jtpio jtpio added the ext:logout Log Out Extension label May 7, 2019
@jhgoebbert
Copy link
Author

Hi jtpio,

this is great! Your screencast looks exactly like I hoped it will. This will help alot.
I will add it directly to our Jupyter installation and let you know how that works.

Best,
Jens Henrik

@jhgoebbert
Copy link
Author

I fail to install it with
jupyter labextension install jupyterlab-topbar-extension@0.2.0
jupyter labextension link ./packages/jupyterlab-topbar --no-build
jupyter labextension install ./packages/jupyterlab-logout

returns:
src/index.ts:7:25 - error TS2307: Cannot find module 'jupyterlab-topbar'.
7 import { ITopBar } from "jupyterlab-topbar";

Can you give me a hint?

@jtpio
Copy link
Member

jtpio commented May 8, 2019

Oh you're installing it from the source.

If you are willing to wait a little, I'm planning to do a release soon.

@jhgoebbert
Copy link
Author

No problem. I will wait for the release.

With the old release jupyterlab-topbar@0.1.1 I get the following error while installing:
jupyter labextension install jupyterlab-topbar@0.1.1 --debug
[...]
File "/usr/local/software/jureca/Stages/Devel-2019a/software/Jupyter/2019a.1-gcccoremkl-8.3.0-2019.3.199-Python-3.6.8-goebbert/lib/python3.6/site-packages/jupyterlab/commands.py", line 1257, in _install_extension
raise ValueError(msg % (extension, '\n'.join(messages)))
ValueError: "jupyterlab-topbar@0.1.1" is not a valid extension:
No jupyterlab key

@jtpio
Copy link
Member

jtpio commented May 8, 2019

The jupyterlab-topbar is not a JupyterLab extension, but a package to expose the topbar interface to other extensions (which is why it's giving this error).

Have you tried to setup a development environment from the logout-ext branch? https://github.com/jtpio/jupyterlab-topbar/blob/logout-ext/README.md#development

@jtpio jtpio closed this as completed in #20 May 13, 2019
@jtpio
Copy link
Member

jtpio commented May 13, 2019

Just released the jupyterlab-logout extension. For now it is still targeting JupyterLab 1.0, so to install it:

# upgrade to JupyterLab 1.0 alpha
python -m pip install -U jupyterlab --pre

# use 'next' tag for JupyterLab 1.0 compatibility
jupyter labextension install  jupyterlab-topbar-extension@next jupyterlab-logout@next

I will consider doing releases for the 0.35.x series later on.

cc @jhgoebbert

@jhgoebbert
Copy link
Author

Great, thanks.
Unfortunately, for our installation we have to stick with the 0.35.x series for now, because it is used in production.

@jtpio
Copy link
Member

jtpio commented May 28, 2019

@jhgoebbert I did a release for 0.35.x, so you can now get the extension with:

jupyter labextension install jupyterlab-topbar-extension jupyterlab-logout

Feel free to open a new issue if you have any feedback or comments you would like to share!

@jhgoebbert
Copy link
Author

jupyterlab-logout is doing a great job! Thank you.
We added another button called "Control", which points to "hub/start"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ext:logout Log Out Extension new-extension Idea for a new extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants