Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for other themes #94

Open
jtpio opened this issue Jul 26, 2023 · 2 comments
Open

Add support for other themes #94

jtpio opened this issue Jul 26, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jtpio
Copy link
Member

jtpio commented Jul 26, 2023

Transferring jtpio/jupyterlab-theme-toggle#3 here in this repo.

For now the theme toggle extension only support the dark and light themes:

const themes = [
'JupyterLab Light', // Light Theme goes first
'JupyterLab Dark',
];

However this could be made configurable via the settings system.

@mahendrapaipuri
Copy link
Collaborator

How do you envision this? Changing to sort of dropdown component and letting users to configure more than two themes or still use toggler component where users can configure two themes at a given time?

@jtpio
Copy link
Member Author

jtpio commented Aug 3, 2023

Since there is already the possibility to choose from a list of themes via the Settings menu, maybe limiting the toggle to 2 options would make sense?

End users would go to the settings editor to enter the names of the two themes they would like to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants