Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absorb the Phosphor Project #28

Closed
blink1073 opened this issue Nov 9, 2019 · 33 comments
Closed

Absorb the Phosphor Project #28

blink1073 opened this issue Nov 9, 2019 · 33 comments

Comments

@blink1073
Copy link
Member

The Phosphor project has been archived by the author, and the name is no longer usable. Here we propose to bring the existing code base as a new repository under the JupyterLab GitHub org, and give it a new name. I say we give a week for folks to give suggestions on a new name.
@GordonSmith
Copy link

GordonSmith commented Nov 9, 2019 •
edited

I would suggest using @jupyterlab-phosphor/algorithm (etc.) - While I suspect "phospor" can't be copyrighted, I would still seek written permission from @sccolbert first and if not given, then consider switching - but it is/was his baby and keeping the name will help preserve his legacy on the project.

I have a few housekeeping PRs I use on my fork which may be of interest:

  • Add typescript types to published package (already there, not sure why I thought they were missing)
  • UMD / es6 Support
  • Updated to latest TS Compiler
  • Use NPM instead of YARN (somewhat opinionated, but Yarn was masking some missing dependency issues between the projects)
  • Removal of unofficial dom functions (setImmediate / clearImmediate)
  • Some minor enhancements to the DockPanel
  • etc.

Plus there is a whole ecosystem of visualizations which play well with the DockPanel (Shameless plug):

@bollwyvl
Copy link

bollwyvl commented Nov 9, 2019 via email •
edited by timkpaine

@timkpaine
Copy link
Member

I think its important to keep it as separate as possible, there are plenty of applications that rely on phosphor that don't want to pull in a bunch of jupyter-specific code.

@jupyterlab jupyterlab deleted a comment from sccolbert Nov 10, 2019
@jupyterlab jupyterlab deleted a comment from bollwyvl Nov 10, 2019
@jupyterlab jupyterlab deleted a comment from sccolbert Nov 10, 2019
@timkpaine
Copy link
Member

timkpaine commented Nov 10, 2019 •
edited

Please avoid antagonistic comments, @sccolbert's contributions to this project are extensive and appreciated, and any questions/comments about reasonings for archiving the phosphorjs project should be taken up individually.

@bollwyvl
Copy link

Sure, thanks for cleaning my comment up @timkpaine. We've all invested a lot in this work over the last n years, and I'm personally grateful to everyone I've had the opportunity to work with during that time around the code.

Just trying to point out that a potential downstream would interpret the current guidance as a 🔴 🎩 -style-trademark-thing, rather than a BSD-conformance-thing, underlining the need to get something relatively official out soon which fully complies with the guidance.

@ian-r-rose
Copy link
Member

Here are few possible ideas on renaming/rebranding. I mostly went down a chemistry-related allusion hole, so take these as seriously/not-seriously as you like:

  • Phosphate is a component of the mineral group apatite, which forms a major structural element of vertebrate skeletons.
  • Phosphates form a structural part of DNA and RNA. Perhaps one of the nuclide bases could be a suitable name. Many of them have a sort of medicinal flavor to them, but I kind of like the idea of adenine.
  • In a similar mineralogical vein: monazite is a phosphate mineral which is used by geochronologists to determine the age of various rocks. Perhaps not as nice of a metaphor, but a fun word.
  • The Great Red Spot is a storm that has been storming on Jupiter (note the i) for centuries, and is big enough to swallow several Earths. We don't know for sure why it is red, but one theory involves photochemistry with phosphine. So something like red spot could be a nice name, with the downside that the connection could be proven incorrect with further data from the Juno mission.

@timkpaine
Copy link
Member

@ian-r-rose i was thinking in the same vein, phosphor is an old name for phosphorus, so I was looking at other old chemical names.

Could also go for a moon https://en.m.wikipedia.org/wiki/Moons_of_Jupiter

@jasongrout
Copy link
Contributor

More thoughts on the connection with light:

  • lumenjs
  • flourescent (hard to spell)

More elements close to it on the periodic table:

  • xenon
  • argon
  • neonjs

@bollwyvl
Copy link

bollwyvl commented Nov 11, 2019 via email

@telamonian
Copy link
Member

"What's Jupiter made of?"

Roughly 90% hydrogen and 10% helium. So I would say we should hydrogen as the new name, but someone beat us to that...

@fperez
Copy link

fperez commented Nov 12, 2019

@jasongrout already pointed out (we had this conversation elsewhere) that the name candela is already taken in npm, so it doesn't work. But I'm still going to write down the idea below just in case the direction of thinking is useful to someone to come up with another one... Naming is tricky and it's all about spurring ideas, so even ones that don't work can be useful :) My original note follows:

In Colombia, 'fósforo' is both the element "phosphor" and the colloquial name for match (as in the little wooden sticks with flammable bit at the end), b/c the flammable tip of matches typically has a lot of phosphor in it (or used to, I have no idea how they're made today). And the name for a fluid lighter is --again colloquially-- "candela", which more precisely is a synonym for fire.

The "proper" Spanish words are cerilla (match) and encendedor (lighter), but in Colombia everybody uses fósforo and candela.

The word candela actually exists in English, it's the the SI unit for luminous intensity (meaning it's physical radiance but integrated with the human visual model of wavelength-dependent sensitivity).

@jasongrout
Copy link
Contributor

jasongrout commented Nov 13, 2019 •
edited

Some more suggestions from our meeting today:

  • lumino
  • sol
  • solar
  • lightstick
  • glowstick
  • glow
  • lumo (esparanto)
  • lux (latin)
  • luce (italian)
  • marama (maori)
  • lumio

@jasongrout
Copy link
Contributor

jasongrout commented Nov 13, 2019 •
edited

When we were discussing it, "lumino" kept coming back as a favorite. What do people think about calling the new project Lumino? (feel free to use thumbs up/down, or leave a comment for a nuanced response)

Reasons for Lumino:

  • It's pleasant and easy to say, sort of rolls off the tongue
  • It's available on npm as an org
  • It's Italian for 'a small lamp or light'
  • It's the Latin verb for:
    1. brighten (w/color)
    2. illuminate, give light to
    3. light up
    4. reveal/throw light on

And as one person said, it's cuter than "lux"

@jasongrout
Copy link
Contributor

Also, someone suggested the proper Spanish word for "bright": luminosa

@tgeorgeux
Copy link
Contributor

tgeorgeux commented Nov 13, 2019 via email

@bollwyvl
Copy link

👍 to lumino, but @lumino is taken on npm. Here's a tool for checking availability, since npm makes it kind of hard through the UI. Of the above, @marama is available. If we throw a y at some of them, it opens up a bit, and likely better SEO, anyhow. lumyno kinda sounds like a dynamo, which is cool.

@bollwyvl
Copy link

(sry, just didn't look hard enough, you can check by URL, e.g. https://www.npmjs.com/org/lumino

@jasongrout
Copy link
Contributor

jasongrout commented Nov 14, 2019 •
edited

but @lumino is taken on npm.

By @blink1073, this morning, just in case :)

@choldgraf
Copy link

@tgeorgeux
Copy link
Contributor

tgeorgeux commented Nov 14, 2019 via email

@jasongrout
Copy link
Contributor

More bike-shedding: this is what the package list would look like:

@lumino/algorithm
@lumino/application
@lumino/collections
@lumino/commands
@lumino/coreutils
@lumino/datagrid
@lumino/datastore
@lumino/default-theme
@lumino/disposable
@lumino/domutils
@lumino/dragdrop
@lumino/keyboard
@lumino/messaging
@lumino/properties
@lumino/signaling
@lumino/virtualdom
@lumino/widgets

@bollwyvl
Copy link

🚵‍♂️ 🏠 ed some font ideas

it's nice that https://raw.githack.com is picking up for rawgit... i got 503ed vs the mothership

some criteria:

  • open source (OFL or equivalent)
  • has an l that doesn't look like a 1, or just look cool

On individual fonts:

  • I particularly like the interplay between the serifs on Flamenco: those could be expanded into boxes suggesting dockpanel

@bollwyvl
Copy link

As for the inhabitants of the bikeshed:

I'd love to bring in a jo-like treatment for this... unsurprisingly lu. Lu's probably a bit more boxy than jo, maybe a little more transforming-pet-like, and helps jo get things done. I can imagine a team of lus:

  • delivering messages
  • sending signals
  • interacting with algorithms
  • shopping at the data store
  • playing hide-and-seek/brady-bunch/hollywood-squares in a datagrid
  • plugging together apps
  • typing on a keyboard like ghost in the shell
  • dragging/dropping around DOM with a claw game
  • looking at virtual DOM in a visor
  • listening for properties
  • disposing of stuff (responsibly)
  • painting with a command palette

@bollwyvl
Copy link

When rebooting the docs, it would perhaps be a good time to revisit sphinx-js for the autogenerated parts, which should likely be considered for lab as well.

Also, it would be very interesting to make a mini-jyve for dogfooding the docs with interactive examples... might as well go ahead and ship the typescript interepreter, which basically has all the nuts and bolts for a language server experience, especially with monaco.

@JohanMabille
Copy link
Member

+1 on Lumino.

@blink1073
Copy link
Member Author

I think the consensus if for lumino. I'll give this another 24 hrs for anyone to disagree and then go ahead and start the migration. Cheers!

@jasongrout
Copy link
Contributor

I think the consensus if for lumino. I'll give this another 24 hrs for anyone to disagree and then go ahead and start the migration. Cheers!

Sounds good to me. +1.

@jasongrout
Copy link
Contributor

IIRC, we were going to release packages with exactly the same commit as the last released phosphor packages to make the transition for anyone literally a name change (with no code changes)?

@blink1073
Copy link
Member Author

Yes, that sounds right

@blink1073
Copy link
Member Author

I created the repo and made a release of all packages. I did the following:

  • Updated naming, contributing guidelines, and licensing
  • Removed auto-generate docs for now - I think we should target RTD

@vidartf
Copy link
Member

vidartf commented Nov 18, 2019

@blink1073 Thanks for handling the logistics here! Would you now say that the process is completed, or are there any remaining tasks?

@blink1073
Copy link
Member Author

Sounds good, I created jupyterlab/jupyterlab#7534 to track the rest of the transition.

@tgeorgeux tgeorgeux mentioned this issue Nov 20, 2019
Closed
@meeseeksmachine
Copy link

This issue has been mentioned on Jupyter Community Forum. There might be relevant details there:

https://discourse.jupyter.org/t/is-phosphorjs-no-longer-supported/3451/2

@Pines-Cheng Pines-Cheng mentioned this issue Dec 7, 2020
Open
@Pines-Cheng Pines-Cheng mentioned this issue Jan 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests