Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State of the 2.x branch? #222

Open
jtpio opened this issue Dec 12, 2023 · 4 comments
Open

State of the 2.x branch? #222

jtpio opened this issue Dec 12, 2023 · 4 comments

Comments

@jtpio
Copy link
Member

jtpio commented Dec 12, 2023

There is a 2.x branch on the repo: https://github.com/jupyterlab/jupyter-collaboration/tree/2.x

There were a couple of alpha releases made from that branch, for example: https://github.com/jupyterlab/jupyter-collaboration/releases/tag/v2.0.0alpha4

Now there is a new 2.0.0 release (no beta or rc): https://github.com/jupyterlab/jupyter-collaboration/releases/tag/v2.0.0

Questions:

  • are the changes in 2.x not needed anymore?
  • should the 2.x branch be deleted?

cc @davidbrochart who made the 2.0.0 release and might have more information and / or context?

@jtpio
Copy link
Member Author

jtpio commented Dec 12, 2023

More context and documentation in the changelog would be useful to users who were already using the 2.0.0ax releases, for example: #219

@davidbrochart
Copy link
Collaborator

I think the 2.x was based on y-crdt/ypy-websocket#86, which I didn't approve, so I don't see myself taking the 2.x branch further.
I'd be in favor of dropping 2.x, but happy to hear other opinions.

@jtpio
Copy link
Member Author

jtpio commented Dec 12, 2023

Also for the 2.0.0 are there any breaking changes users should be aware of, which could break deployments?

Are there general improvements to the RTC experience with 2.0?

Or is it mostly a swap of an underlying library without users noticing?

@davidbrochart
Copy link
Collaborator

It is mostly a swap of the underlying CRDT library (ypy -> pycrdt). There were also some improvements, new tests and bug fixes by Carlos (see the changelog).
There are no breaking changes users should be aware of. Pycrdt has a different API than Ypy, but these changes are in jupyter-ydoc, which also got a major version bump.
I would say that only the fact that pycrdt is up-to-date with Yrs, while we were using a very old Yrs version in Ypy, could fix a number of bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants