Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some global "search" or "find" required #17

Closed
stephenholtz opened this issue May 30, 2017 · 4 comments
Closed

Some global "search" or "find" required #17

stephenholtz opened this issue May 30, 2017 · 4 comments

Comments

@stephenholtz
Copy link

Opening to see how people foresee handling "search/find" commands inside the app. Using chrome's default browser behavior might provide some consistency across platforms(?). However, it would be nice if there were some more advanced search/find-replace method similar to in other IDEs... perhaps this discussion belongs in the jupyterlab main repository.

(Thanks for setting this up! Works like a charm 🥇 )

@ddavidebor
Copy link
Contributor

Electron does not support the standard chrome search features. It exposes APIs to interact with the underlying in-page search engine, but no UI of any sort.

If thus a feature was available in jupyterlab (see jupyterlab/#1074 ) we could bind ctrl+F
/ cmd+F to it.

@stephenholtz
Copy link
Author

I see, so this really belongs in the jupyterlab. Thanks for the info

@ellisonbg
Copy link
Contributor

ellisonbg commented May 31, 2017 via email

@stephenholtz
Copy link
Author

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants