Unable to set email/username on a remote server

[jzhang20133]

Fixes #1323

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[github-actions]

👈 Launch a Binder on branch jzhang20133/jupyterlab-git/email_username_popup

[krassowski]

The liner suggests to use triple equals here. The argument annotation says it cannot be undefined so it should be equivalent:

Suggested change

	if (path == null) {
	if (path === null) {

Unless this fix depends on it, then we need to change linter eqeqeq rule to smart and add undefined in the argument.

Also, can you add a test?

[Zsailer]

Nice! Thanks @jzhang20133!

This LGTM. @fcollonval I don't have access on this repo. Would you mind helping me merge and release a patch here? I can pick this up too if you want to give me access here.

[Zsailer]

Also, can you add a test?

@krassowski I dove into this a bit. It appears that we're skipping most unit tests for this panel since the JupyterLab 4 release. (see here, here, here, here, and here). I believe this is the reason the current bug wasn't detected in the first place. Removing and of the .skip calls causes these tests to fail, so it seems that the API changed somewhere along the way and the tests were never updated?

I think it's beyond the scope of this current PR to fix all of these failing unit tests. For the sake of addressing the current bug, I would propose that we merge the current PR without additional unit testing.

Further, it seems that the workflows for this repo have been failing for quite awhile due to some dependency resolution errors.

[Zsailer]

I've opened the following issue to track work on re-enabling the skipped unit tests (hopefully in a follow-up PR): #1325

[krassowski]

I don't have access on this repo. Would you mind helping me merge and release a patch here? I can pick this up too if you want to give me access here.

I've added you as a collaborator, but let's get the CI green before merging - thank you for opening #1326!

[Zsailer]

but let's get the CI green before merging

Done, @krassowski 🚀

I'll try to get the (skipped) unit tests working for the Git Panel. If I can't get that done today, I don't think we should block this PR.

[Zsailer]

Amazing work, @jzhang20133! Thank you so much for taking it the extra mile to fix all unit tests and adding a few new ones for this PR! 🚀

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️

[Zsailer]

We'll need help with releasing this bug fix, since we don't have admin access to this repo.

I think it would be worth updating the Github workflows for releasing to use the latest work happening in Jupyter-releaser with project level PyPI tokens.

[fcollonval]

Thanks a lot @jzhang20133 @Zsailer and @krassowski for the latest work; v0.50.1 has been released with the latest fixes.

[Zsailer]

Thank you, @fcollonval! We appreciate you and @krassowski tremendously! ❤️