New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JupyterLab file browser entries empty with this extension installed #411
Comments
Hey @02JanDal, is it possible for you to update Jupyterlab in the docker stack? It looks like, some Jupyterlab packages are incorrect when rebuilding the application with the extensions. |
It looks your problem may have been fixed by jupyterlab/jupyterlab#7182 |
I think this may be the same thing as jupyterlab/jupyterlab#7189 (comment) |
There's a fix now as part of jupyterlab/jupyterlab#7192 After these changes are published, do a clean build:
|
Awesome! Will I need to wait for a new release of JupyterLab (1.2?) or will the changes be pulled in regardless upon running those commands? Closing this issue meanwhile, will reopen if the problem persists. |
@02JanDal The changes will just get pulled in upon the rebuild (this is actually an unfortunate design flaw in the build system that was fixed in Jlab |
…ening non utf-8 encoded files Adam Gruenbaum (1): fixed center-aligned images with IPython.display.Image Adityar Rayala (7): Added the Selection of cells till Top and Bottom Fixed Changes causing error Added parameter documentation and updated labels Restored old definitions and changed comments Updated changes in example notebook to default definitions Changed the test-notebook function and added the call with true parameter Added checks in test-notebook Afshin T. Darian (70): Minor clarification of comments, removing old comment. Block fetching the settings for a plugin that is disabled. Address @vidartf's comments. Remove deprecated shortcuts plugin. Add Extension namespace and functions to PageConfig. Remove filtering from settings service. Handle setting plugin filtering at the setting registry plugin level instead of filtering via the service manager. Update dev_mode index file to use new PageConfig functions and fix disabled bug for individual plugins. Remove superfluous type annotation. Update staging index. Clean up disabled/deferred handling. minor update Add a query to the setting registry list method. Add optional query typeparam to data connector. cc: @jasongrout @saulshanabrook Load deferred plugins manually after the application has restored Update deferred settings load logic. Shorten setting registry transform timeout. Try to load deferred extensions settings after the application has restored. Update doc strings Update message. Move setting connector to its own file and clarify loading deferred plugin settings logic in a comment. Switch to using Lumino polling package. Clean up codemirror imports. Guarantee `titleCase` never fails, even if undefined `str` is passed in. Make optional dependencies explicitly typed. Add `restore` flag to file browser widget instantiation options. Create a tree resolver token and interface. Rewrite tree handler plugin to be a tree resolver instead. Add `populate` flag to file browser restoration. Use the tree resolver as an optional dependency to populate the default file browser. Refactor file browser restore method and fix instantiation logic. Fix strict null check errors. Restore default file browser manually; fixes #4009 Tweak path test. Explicitly create a Panel instance for each ConsolePanel instead of passing it in. Change isActivate back to activate. Fix console restoration. Query list() calls based on an explicit namespace match instead of a starts-with match. Fixes #7257. Update list() test to fail under old behavior but pass under new. Update docstrings. Update docstring for restorable pool add. Appease lint. Update p-* selectors, events, and data attributes to lm-*. Formatting Fix app example icons. Fix cell example icons. Fix console example icons. Fix filebrowser example icons. Fix notebook example icons. Fix terminal example icons. Formatting Remove unused svgo dependency. Update yarn.lock files Add initial extension migration guide. Add to TOC Add phosphor to lumino table. Add note about deprecated prefixes. Update table and introduction. Fix typo Update language about package versions and change deprecation note to a warning. Start list of JupyterLab imports that have changed. Update former coreutils list. Initial block for session and session context docs. Add session context example. Add link to debugger service diff in PR. Add @jtpio's note about await ready. Update session note. Add link to services readme. Fix building docs for settingregistry package. Add package data to setup call. Alex Bozarth (4): Moved config into commands.ts Support transient editor configs Close Dialog by clicking ouside of it Fixed wrapSelect to support multiple selects Andrew Carlson (2): add download command to file menu remote console.log Andrew Schlaepfer (1): add scrollbar styles to nbconvert-css Ben Thayer (6): Fixed multicursor backspacing Fixed build errors Changed variable for clarity Fixed backspacing newlines Changed var to let and == to === and != to !== Added split-cell multicursor Borre Mosch (1): Added env prop to kernel options Borys Palka (2): change ConsolePanel to MainAreaWidget<ConsolePanel> change tracker from MainAreaWidget back to ConsolePanel Brian Austin (1): Update Contribution Guide to require node v12+ Bruno P. Kinoshita (1): Fix project name typo Daniel Marth (1): fixed file browser location in tree view and removed parameter from URL Declan Kelly (9): Add test for metadata in kernelspec model Added metadata to spec model & validate Add env validate and test Add Automatic Labelling of PRs Remove comments, add missing packages Switch Auto-Labeler to Periodic Labeler Update .github/workflows/labeler.yml Fix Labeler Workflow Update Periodic Labeler Dharam Kapilaa (1): Added hash to the csv delimiter types Dominik Moritz (5): Call result.finalize to prevent memory leaks Update index.ts Update index.ts Update package.json Update yarn lockfile Duarte OC (1): Doc dependencies in environment.yml Frederic Collonval (4): Fix #7456 Test jupyter lab without nodeJS Launch with log capture Optionnaly force new browser tab Frédéric Collonval (5): Fix yarn registry with command argument (#7109) Add comment when using custom yarn registry Correct configuration parameter name Add feedback on the debug channel Correct bad copy-paste in doc Gajanan Bhat (1): Abc widget factory docregistry dispose signal(5843) (#7833) I501908 (3): fixed alignment issue for select box arrow icon inside dialog Fixed refresh issue for html viewer(slides)-7552 fixed the css to fix filter box cut off issue when only one row in json output Jason Grout (263): Convert output console to use MainAreaWidget Void an unhandled promise. Use the message date instead of requiring a new date. wip wip wip wip More wip WIP Add logic to put log viewers on the page. Make typings for clientsession iopubmessage signal handler more precise. Let anyone set the rendermime for a logger, so we lazily create it only when a message is sent. Simplify prompt creation Revert staging back to the published version from df6e99cd9932cc06b2465e805b8d493e04fd9765 tweak release test script to deactivate test environment Publish bump version update core mode script to include necessary webpack scripts Publish 2.0.0a0 Fixes context menu hit test to deal with svg nodes. Use temp directories and error handling better in release process and release testing. Integrity updates. Rename tsx file that does not actually use react. Fix integrity issues with new logconsole packges. Fix NASA link in docs so the docs check passes. New version bump version Publish 2.0.0a1 Skip custom click behavior on links when the download attribute is set Fix Safari multiple tabs by working around a Safari bug. Update marked to 0.7.0 Add changelog for 1.2 Add changelog note about #7336. Change log console activeSource to just source Make log console creation options include layout and source. Change toolbar buttons to command buttons so they can be disabled easily. Handle attached signals with show/hide messages instead Add a sourceChanged signal and use it to notify of command changes. Simplify logic for switching the log console source. Simplify react rendering logic slightly. Factor out the log console status bar component to a separate module. Make the info colors consistent with usage elsewhere in JLab. Activate log console widget through the shell. Make more dependencies optional Push the max log size down to the model Populate console on attachment Fix status bar flashing state when log console is created. Simplify the status bar components Change log console highlight to use brand color. Track whether a log has ever had a message, and hide the status bar widget for inactive logs. Override the typestyle font color when log console status bar item is highlighted Move list icon to ui-components package. Use the new icon system for log console. Add a log console plugin to log all notebook outputs. Exploration for how to communicate to the right components that current messages have been displayed. Revert "Exploration for how to communicate to the right components that current messages have been displayed." Refactor logger and registry into separate files. Clean up typo and unused code. Add a scrolling widget. Fix the scrolling widget to work well. Move the scrolling widget back to the LogConsolePanel. Fix tracking of scroll position across toggling consoles. Clean up ScrollWidget typings Set up a system for log versions that enables notification and display tracking. Fix scrolling widget initial display to scroll to bottom. Fix an initial log console rendering with no source. Add todo Do more careful handling of null sources. Delete unnecessary todo Carefully account for message display to fix bugs and remove unnecessary code. Reorder code to follow JLab guidelines Add todo item about the notebook output logger. Integrity fix Fix log console tab icon Remove notebook output logging. Revert "Remove notebook output logging." Teach CommandToolbarButton about optional command arguments Add rudimentary support for log levels Make css class name more consistent with our conventions Log notebook unhandled iopub messages with warning or error levels, as appropriate. Refactor notebook output logging code Add prompt colors and tooltips for log severity. Add optional template parameter for IChangedArgs for better typing. Add UX for switching log level. Prettify Cycle through logging levels for notebook outputs. Add a ‘metadata’ log level, and change checkpointing/level setting to use it. Fix the log level toolbar control styling. Reorder import statements. Integrity fix Add initial tests for log console. Add logger registry tests. integrity fixes Add tests for the log console panel Add disposal methods and use them where needed. Integrity fixes. Fix status bar notifications. Revert "Cycle through logging levels for notebook outputs." Whitespace change to get CI to run again. Set the class name correctly (never set to boolean). Do the browser default behavior when clicking on a label in a toolbar. Update release test script to work in a subshell Update changelog for 1.2 Update order of changelog issue references fix link Make the log console status bar widget display new messages, not just log entries. Output area calls a new protected function to determine if outputs should be combined. In the logger, only combine outputs if they have the same second (which is the resolution for our timestamp). Update the log prompt title to include the full date Use `which` to find the right command to run to rebuild jlab Update the ui-components css to reflect the correct dependencies. Update status bar index.css to be hand-curated. Upgrade to Typescript 3.7 final Disable type checking vega-lite libraries. Update typedoc to 0.15.2 Migrate typedoc config to more conventional typedoc.json files Work around bug in giving include files and having composite true Update prettier to support TypeScript 3.7 Formatting updates from the prettier upgrade. Handle cell execution cancellation because cell is disposed. Allow shortcuts to be empty and to have win/mac/linux-specific keys. Integrity updates for the cell-tags extension. Simplify async logic by using an async anonymous function. wip Update kernel status to have a connection status and a kernel status. Fix many test failures. Updated session to proxy the connection status from the kernel. Delete unnecessary awaits for kernel info replies. Rework session and clientsession status to just point to the kernel status. Document an overview of the client session / session / kernel architecture. Refactor validation functions Move kernel spec functionality to its own module, with its own manager, etc. Factor out common things from the managers into a base manager. Change session kernel changed signal to be a real IChangedArgs signal. Use kernel status directly instead of session status. Move kernel rest api communication to new restapi module and caching to the kernel manager. WIP update session to mirror new kernel refactoring. WIP update for session manager Refactor connection construction options and various places models are transferred. WIP Fix remaining compile errors in services package Update services to use new TS 3.7 null coalescing and optional chaining syntax. Use ts 3.7 assertion functions to improve typing. Update core plugins for the changes in services and ClientSession. Clean up a few more changes we’ve made. More correctly use the status in change signals in clientsession. WIP clean up tests and kernel starting signatures Reorganize kernelspec and kernel modules to use modules instead of namespaces. Update services tests and fix relevant bugs. Export kernel spec rest api wip wip Rename clientsession files to sessioncontext Clean up documentation and api for session context Clean up kernel api Change status bar code to indicate kernel sessions, not just kernels Update completers to handle session changes More API and docs cleanup. Fix lots of tests Trigger ‘restarting’ status ourselves when we initiate the kernel restart. Fix more tests Rewrite some of the sessionContext logic as async/await and fix tests. Work through tricky logic around disposing dead kernel connections. Fix almost all of the services tests. Fix session context tests Fix the kernel toolbar indicator to show the kernel connection status when not connected. Fix rendermime tests Add more testing options for comprehensive running tests Add initialize and ready/isReady methods to session context. overhaul the test createFileContext utility functions Fix more tests. Fix remaining failing tests. Fix compile errors Package integrity updates Remove the sessionContext.kernel convenient shortcut. Clean up comments and formatting. Make status bar explicitly and accurately have a tooltop of “kernel sessions” rather than just “kernels” Fix linting errors Fix tests Fix tests Fix building examples Take care of some TODOs that are no longer applicable. Clean up some old TODOs Change kernel.connectComm to kernel.createComm and add a new hasComm method. Allow reconnections for disconnected kernels Only try to reconnect if the kernel connection is not disposed Delete old test comment Update testEmission to use optional chaining and null coalescing. Fix skipped test Fix some problematic logic around reconnections exposed by the tests Fix comm test Test sessionContext shutdownOnDispose Clean out more TODO notes. Change .getSpec() to just .spec, to mirror the .info promise. Resolve another TODO item by deciding against it. Make the session and kernel interfaces more consistent Fix kernel connection spec promise calls. Fix a few more tests from the session manager signature changes. Another pass updating the services readme. Separate out the kernel and session creation vs connection options in the manager startNew methods. Make slots class methods since we are now passing in the `this` context in the signal connection. Restore original jest timeouts. Add connectionStatusChanged signal to session context. Remove debug logging. Add a convenience session context .kernelDisplayStatus Fix an error where the handler used a variable before it was declared. Fix compile issues from a mis-merge. Integrity updates to fix an error from removing vega4 Remove obsolete test Linting fixes When creating a test session context, make sure the spec manager is ready before using it. Explicitly test kernel preference starting values to have the right defaults of true. Fix usage examples. Add tests for session context kernelDisplayName and kernelDisplayStatus Move example code for services into tested files. Service manager ready should depend on kernelspec manager ready. Add some more documentation to the services readme. Streamline test that often times out on Windows and raise timeout limit Up timeouts on tests we seem to be getting timeouts on in the windows CI. WIP Rework terminal to follow the conventions and design of kernels and sessions Bind the appropriate `this` context for a setTimeout callback in kernel reconnect attempts. Simplify connection status update logic. Tweak kernel tests to be more correct and complete. Initial pass on reworking the services terminal code to be consistent with the kernel code. Fix compile errors and behavior when shutting down a terminal. Delete obsolete commented code Bind a setTimeout callback properly to `this` A catch function *must* have an empty function to properly catch errors. Fix dispose logic errors in kernels and sessions. Fix terminal tests, and issues exposed by the tests. Fix reconnect test. Fix examples Fix compile error Fix terminal tests. Send a terminal stdin message to make sure to get output. Revert ensure-max-old-space now that node 12+ has better default memory ceilings. Integrity fix - buildutils no longer depends on which. Update yarn.lock Fix null check error Upgrade yarn in staging to 1.21.1 Delete and regenerate yarn.lock to refresh dependencies Be more careful about sessioncontext kernelChanged and sessionChanged signal emisssions More careful sessioncontext dispose logic More yarn.lock updates from a simple pip install and jlpm run build. Save the intended console path, preventing doubling of consoles each refresh. Teach update-dependency about more range specifiers and make it adopt the current range for any tag. Update changelog 2.0 header Small changelog edit. Make sessionConnection take options for the kernel connection. Make sure the help menu extension never claims it can handle comms. Shorten the logic slightly with optional chaining. New version bump version Publish 2.0.0rc1 Support comparing semver ranges that have top-level `||` operators. Fix corner case comparing semver ranges. Fix milestone script New version bump version Publish 2.0.0rc2 Update changelog for 2.0. Reordering and rephrasing user-facing changes in changelog to be more informative. Fix migration note about kernel.info Jeff Laiosa (1): Change the NASA link back to point to the API key documentation Jeremy Tuloup (22): Remove unused side parameter Add support for rank to shell.add(w, 'top') Add rank test for shell.add(w, 'top') Try keeping the same area order Fix typo in comment Add Enable button for installed extensions only Remove unused IRouter from the hub extension Add types for the Mardown cell ActivityMonitor Add types to DocumentRegistry activity monitors Add UseSignal example to the docs Fix docstring for MarkdownViewerFactory Align buttons in the running tabs Close output views on notebook closed Update notebook tools on tracker.currentChanged Update docstring for the Session Context Update MathJax CDN in cell and console examples Change CommonJS to JavaScript in extension dev doc Align celltags UI in the notebook tools Match react in ui-components peerDependencies Update list of core tokens in extension dev docs Update import for the StateDB example in dev docs Remove mention to IIconRegistry from the docs Joël Billaud (4): Expose a running session registry Register the running kernel manager Register the running terminal manager Update packages dependencies Katsarov (2): [Docs] Add table of contents in 'Common Extension Points' documentation update: better overview about contributing to JupyterLab + move up in the menu Konstantin Taletskiy (1): Typo in UseSignal documentation Luciano Resende (13): Enable special case for when updating dependencies Update backward compatible dependencies to latest version Update MarkedJS types Update linters and linters configuration Update to Xterm 4.3 Update backward compatible changes to codemirror and its types Update css-loader to '~3.2.0' to avoid Firefox load issues Revert to xterm < 4.3.0 to avoid theme/style related issues Simplify user experience when selecting 'no kernel' for notebook Sort maintainers list in alphabetical order Fix missing deduplicate command when using build:core Fix error message during invalid extension install Update suggested build type on troubleshoot msg Marc Udoff (14): Allow max-old-space to be specified outside of jlab Support for output search Fix issue with saving modified nodes Add filter on search to only search input or output Added a shortcut to go to the last run or current running cell Fixes per review One more review comment fixed Fix lint error When timing metadata changes, ensure metadata.changed fires Allow for a global track timing setting Clear execution metadata with count Clearing execution should also clear related fields Add command to open find with replace Remove hotkey Marisa Aquilina (2): Resolve unexpected jump issue RemoveUntitled notebook Matthias Geier (3): DOC: Add README for Binder config files Binder: Add a few dependencies Update Binder README Max Ehrlich (8): Package integrity updates Incorporating review feedback Fix package integrity Integrity fixes from merge Lint on contributing.md Use disposable to remove running managers Fix shut down wording Package integrity updates Maximillian (1): apply options to initial instance Mehmet Bektas (69): Output Console extension initial commit update log line layout, use color variables to support theming find right sender session for message, show sender icon, prevent log duplication fix subscription problem when connecting existing kernel sessions use signals for log message subscription show log counts as a flashing status bar item, launch output console from status bar expose anyMessage from ServiceManager and use it to capture in Output Console use list icon for output console tab panel remove app.started wait move console log notification from status bar to notebook toolbar, auto-filtering by notebook session, refactoring handle session not found by kernel id case properly add missing comments, make method private stop showing all messages in output console, refactoring flash new message notification when log list is not in view support message filtering using UI actions fix nblogger logging issue single panel for all outputs from different sources, move notification to status bar, refactoring proper log status display and flashing show log timestamp in prompt area, flash & message limit settings simplify prompt widget generation support for removeRange from output model apply limit to output console items use timestamp as number support restoring output console panel propagate message limit on initialization, fixes for other limit related bugs make sure activation with no logs doesnt cause status highlight rendermime changed signal, fix flashing enablement initialization fix scroll to bottom on activate return length of output area model prevent changes to original output data launch from view menu and command panel show placeholder if no logs exist new log console icon handle closing of notebook properly Clear and Add Timestamp toolbar buttons set output_type without modifying original message add thisArg use system rendermime by default context menu access to log console rename Contextual Help to Show Contextual Help refactor & rename export only needed, further refactoring rename packages from outputconsole to logconsole clear TODO items rename and clean CSS comments / documentation better status bar item state handling, refactoring check for log count before highlighting on activation Package integrity updates increment package versions to match the rest remove test code change package versions add comment for reverse loop deep copy value in set update tdoptions to match other packages fix lint errors fix lint error prevent animated scrolling to bottom when source is activated add support for plain text and html logging refactor into index, tokens and widget files refactoring and comments for new types reset log display and count when non-notebook tab gets activated activate new current tab move tab activation code to application-extension activate new current tab only if there isn't an active one make sure label is linked to a control check if label for attribute defined update dropdown widget to make sure it reflects new state fix dropdown option style issue in Windows Min RK (1): define base shareUrl Nicholas Bollweg (3): #7368: use setdefault for buildAvailable and buildCheck fix documentation documentation link change from #7378 add docs for disabling build checks Nick Morris (1): Typo in ISchema documentation Paweł T. Jochym (1): The title has a typo Raffaele De Feo (1): Fix CSS style declaration property name. Ryan Grout (9): Normalize keys taking in a platform aware way. Fix wording of warning messages. Reorganize shortcuts documentation for clarity. Use normalizeKeys from lumino/commands. Upgrade @lumino/commands Update yarn.lock Update @lumino/commands. Package integrity updates Update @lumino/commands (try 3) S. Chris Colbert (1): Don't export the Private namespace Saul Shanabrook (29): Update meeting notes link to hackmd Only delete execution timings on clear outputs cmd Remove record timing notebook metadata Dev mode update phosphor -> lumino Remove unneeded tsingore Move filter button to replace line when able Keep buttons in the same place as you expand Space properly on dropdown Switch to ellepsis button Move filters to bottom Search input by default Only show outputs toggle in notebook Add basic styling for search options Only show filter in notebook and disable when find and replace Remove search options header Make text label for checkbox Make search options grey if disabled Switch to ui color 3 Switch back (wrong component) Show if search options are enabled Yarn lock updates Make typings more strict Integrity update Fix null checks Change phosphor instructions to lumino for linking Update display after showing replace Rename functions Don't update display Simon Biggs (1): Update package.json Steven Silvester (178): Remove datagrid as a singleton update affiliation Update imports Alias phosphor packages to lumino packages update links Update docs Update mock package for test Update test deps more test import changes more renaming update testutils update buildutils update examples Update yarn.lock Update yarn.lock address review lint Remove phosphor shims Update datagrid usage and fix more imports Add mouse, key, and selection handling Update test more remaps add header to auto-generated files Clarify comment bump version bump version New version bump version New version bump version Update logconsole dep Update deps update yarn.lock Update deps update for release update terser plugin New version bump version integrity updates Update file check updates to release process add minor version spacing Update ci script clean out the staging directory when updating core mode update ci script add beta handling for js Add storybook to ui-components integrity update yarn.lock Update deps undo local changes update deps integrity drop vega4-extension integrity integrity changes clean up integrity script update ci script Use consistent versions of React update handling of notebook edit mode [skip ci] spelling Fix handling of input area refresh Always create a model with an empty cell update docs and add tests update name and behavior to better reflect intent Allow metadata for launcher items Pass in the metadata as kernel metadata Strict null handling lint wip add property inspector address review comments lint Remove currentChanged shell handler fix jest config integrity Make session dialogs configurable Clean up strict handling clean up typings Update docstrings strict nulls fix test strict nulls Address review comments Clean up handling of sessioncontext initialize fix example test header try running the node test in the temp dir try the node test directly Ignore node in the test runner Run the node test in isolation revert changes and run example tests once add public access to celltags-extension Clean up UX of property inspector Add public access setting for public packages Compare final release versions update docs fix spelling Only affect the x1 prerelease address todos and deprecations for 2.0 revert unintended change remove deprecated import cleanup fix module location update test cleanup Replace missing kwarg Replace missing kwarg clean up handling of linked extensions first draft of changelog address review Add celltags image and clean up language Remove link entirely for now Make the dropping of prereleases optional in the standalone functions add data-icon attribute Add a className to the breadcrump ellipsis Update tests integrity Pin nbformat for now remove pins fix pipeline config New version bump version New version bump version New version bump version integrity Publish 2.0.0b2 Update notebook toolbar example Update apod tutorial for beta Point to beta tag of cookiecutter point to 2.0b2 branch fix tag links increase timeout for binder launch resolve conflict increase timeout again specify not to use the redirect file try a newer version of the proxy use latest notebook try an explicity ip try with just ip change Increase timeout again Add a note about the server logs bump lumino dependencies integrity bump commands integrity fix removal of dependencies Add link to overview youtube video fix log console icon location add debug output for azure Install puppeteer in a temp dir create a local package.json file so it is self-contained restore accidentally removed line New version bump version Publish 2.0.0b3 fix docs and add changelog entry update ci_script allow other svg attributes in test Add changelog entry for jupyterhub Add JupyterHub note to installation and clean up change log Fix docs environment New version bump version Publish 2.0.0rc0 bump ui-components version Publish 2.0.0rc0 Fix bumpversion script to properly switch to alpha for a minor release Alias phosphor packages to lumino switch to pip for rtd Add requirements file fix config path readthedocs doesn't use name field anymore do not install the package itself on readthdocs bump test-logconsole version New version bump version update yarn lock Publish 2.0.0 Sylvain Corlay (2): Add password dialog Add documentation T. George (4): Update palette.svg Adding Max to readme Update README.md Fixed incorrect white background Thibault Derousseaux (3): Don't display node structure in json-extension Only show node structure when there is no data Only display node structure in JSONTree for arrays and empty objects Vidar Tonaas Fauske (43): Update lumino coreutils for partial JSON Use partial JSON types in coreutils tsconfigbase schema Enable strict null checks for coreutils Simple strict null fixes improve signature coreutils.path.stem always fails? Throw errors for undefined settings fetch fail Remove coreutils/path/stem Regenerate yarn.lock (deduped) RestorablePool current nulls Cleanup statedb Update restorablepool.ts Fix lint commands for windows Update to lumino/commands 1.9 Turn on strict null checks (except for services) Add generic arg to IChangeArgs helper Simple typings changes for strict nulls Might supress wanted errors non-null asserts Vdom always has model dispose Logic changes More partial types misc uncertainties integrity Fixes for default value of session clientId Clean up some tests Create package nbformat Move nbformat code to separate package Create package settingsregistry Some cleanup after package creation Rename settingregistry package + tests Create package statedb Move StateDB code to new package lint Fix settingeditor-extension README link Fix docs for new packages Allow main app ext to work without palette Make palette (and a few others) optional when possible rebase fixup app-ext: put all palette commands together Wolf Vollprecht (3): remove removing ws add missing shim file fix up the shim Yoni Lavi (1): Minor typo - s/Jupter/Jupyter/ YuviPanda (1): Add explicit doc encouraging people to re-use lab components Zsailer (2): bump ts version switch phosphor to lumino dependencies bw-space (1): Changed the Shortcut to select to Top and to Bottom dLamSlo8 (1): updated setting change listener to notify the registry that command changed ggbhat (2): Ux change for extension manager pagination Enable lineWiseCopyCut option in settings for notebook and codemirror i342302 (2): Fixes jupyterlab#6827 fixes #7141 : display proper error message while opening non utf-8 encoded files ikiw (1): Fix codemirror lineWrap max-width madhu94 (1): Allow different mimetypes on the clipboard marisaaquilina (1): Link the code snippets of UseSignal examples markellekelly (22): added celltags extension added header, css fixes fixed icons & css for dark mode fixed to use defaultIconRegistry added docstrings, fixed some function names, updated package.json small fixes updated package.json, debugging adjusted to pass linux integrity tests bug fix check for tracker.currentwidget prevent text highlighting Update packages/celltags/package.json fixed interactions with add widget css removed comments/small fixes added functionality to plus button fixed focus problem when changing tabs + removed console logs fixed readmes, final code cleaning added shortcut to file browser tooltip changed function name added command for restart and run to selected moved to kernel menu martinRenou (1): Upgrade Font Awesome to 5.12 mwojton (3): Adding file size to File browser hover Adding path, size, created/mod to hover changed time format to YYYY-MM-DD HH:mm:ss nmadhum (2): Debounce search queries in the extension-manager extension. Changes to setting editor should trigger application qntnrbns (2): Add new file and new markdown file to context menu added commands to move to next/prev tab bar in shell selango (2): Resolve #7874 - stop too many fetch calls to docmanager-extension on first load Fix linting issues #7874 telamonian (272): added fallback flag to `icon`, moved toolbar to new icon handling fixed up icon fallback in listing migrated toolbar button svg files to `ui-components` added toolbar icons to DefaultIconRegistry cleaned up redundant svg files in theme-dark fixed up msgs generated by `ensureFile` removed old CSS for toolbar icon background svgs cleanup added 'toolbarButton' icon styling kind fixed up toolbar icon-related unittests fixed up toolbar unittests in `test-notebook` optionally replace `import` -> `require` when generating iconimports.ts fixes #7189, jupyterlab/jupyterlab-git#411 fix to deprecated docstrings refactored sidebar tab icon styling, fixed right sidebar tab icons removed svg styling from old icon behavior fallback fixed svg toolbar icon labels fixes #7264: use default `app_dir` when it is empty string attempting to make `test-notebook` more robust wrt CI tslint: ignore no-invalid-this for `this.timeout` in mocha clauses refactored `test-console` to be faster/less likely to time out fix to the fix in `foreign.spec.ts` in `test-console` ensure-buildutils.js rebuilds correctly on changes, runs pre integrity attempting to fix failure in `jlpm check --integrity` fixed `jlpm check --integrity` fail by removing `--ignore-scripts` flag rebase; fixed yarn.lock fixes logconsole icon by fixing the icon name replace `lodash` with `@phosphor/algorithm` removed unneeded typing fixed typeerror enable typescript sourcemaps for debugging labextensions --extensions, --settings, --static, --all flags for `jupyter lab clean` added `jupyter lab clean --flag` commands to usage test, as requested added warning about reinstalling extensions to help and `lab clean` output swapped @phosphor -> @lumino in dev_mode/package.json moved settings plugin to own src file; some related cleanup reenables saving settings by adding save method to SettingConnector post rebase integrity in celltags swtiched Button in story to ours; cleaned up storybook tsconfig.json added story for DefaultIconReact bumped versions of celltags and celltags-extension to 2.0.0-alpha.4 increase timeout in isession.spec.ts from 20s => 60s moved vega deps from "devDependencies" => "dependencies" in package.json restores lint-on-commit hook by reverting 0bdce26 starting work on JLIcon, to be used as an icon class wrapper dynamically create JLIcon class within a function added static JLIcon.element, returns an HTMLElement set up ref forwarding in JLIcon simplified typing of createIcon return type all of the wrapped icons now get autogenerated by `integrity` added explicitly declared return type to `createIcon` simplified createIcon function by refactoring it into JLIcon class refactored JLIcon.react from accessor => property fixed up docstrings in JLIcon namespace experimenting with blending phosphor/react vdom all tabbar icons now rendered by blended react/phosphor vdom elements fixed sidebar tab icons; styling still isn't right integrity fixing up the text editor icon fixed text editor icon name progress fixing text editor icon finished fixing text editor icon human readability formatting pass of filetype icon svg switch filebrowser to newest JLIcon icon handling finally got react to parse/render bare svg element without outer div bugfix for camelCase function fixed container handling by JLIcon methods fixed styling of tab manager tab icons fixed memory leak in browser icons; updates for latest version of hpass fixed memory leak; JLIcon nows cleans up after itself when passed to phosphor post phosphor => lumino rebase cleanup progress progress JLIcon prototype is now feature complete and lumino vdom friendly type/signature fixes fixed bug in static Map init fixed tabmanager icon styling fixed style for dockpanel tab icons signature cleanup simplified JLIcon styling for lumino; moved all tab icons to JLIcon docs and integrity post-rebase cleanup and bugfixes integrity picked lint configure all linters to ignore generated iconimports.ts began migrating batch of 17 icons from theme-x-extension to ui-components continuing migration of batch of 17 icons canonicalized names of migrated icons cleaned up/annotated migrated icon svgs improved/robustified the JLIcon.get() icon lookup method migrated icons in `settingeditor` pkg to JLIcon migreated icons in `filebrowser` pkg to JLIcon prevent redundant rerenders of icons created by JLIcon.element() refactor of JLIcon.get into JLIcon.getElement and JLIcon.getReact removed all refs to defaultIconRegistry outside of ui-components pkgs picked lint fix filebrowser unittests removed refs to defaultIconReact and IIconregistry from non ui-x pkgs fixed icon label rendering bug fixed icon titles improve svg loader in storybook's webpack finished moving all icons from theme-x-extension => ui-components finished cleaning all icons out of theme-x-extension packages fixed the names of the arrow icons fixed raw svg for arrow icons migrated Collapse to JLIcon fix unittests fix usage CI migrated all jupyter icon and most arrow icon usages to JLIcon icon renaming more icon renaming finished annotating all svg icons for themeability improved JLIcon._get to allow for dynamic lookup on multiple classNames ellipsis and circle icon migrated to JLIcon integrity migrated undo and finished migrating ellipsis icons to JLIcon integrity fixes #7575: centered v alignment of breadcrumbs home icon removed deprecated IconItem migrated search icons fixed search and caret icon visual regressions removed deprecated "selected" versions of svg icons migrated running item icons to JLIcon more icon cleanup and migration first pass at icon cleanup/migration finished migrated select element icon to JLIcon added CSS for inverting icon colors, and for changing them on hover finished fixing/migrating the close icons set up all in one busy/close/close-circle icon removed final vestiges of deprecated IconRegistry from codebase upgraded lumino deps to pull latest advances in virtualdom icon handling finished cleaning/migrating the caret icons consolidated icon css in ui-components package finished cleaning up icons.css added jest-raw-loader to fix some issues with svg icon tests fixed all tests in test-apputils post-merge fixes also pin nbformat in the windows CI added troubleshooting message on build failure fixes to `buildFailureMsg` corrected config file info, fixed some typos in build failure msg disabled pkg dupe check in watch mode to reduce noise in console output delinted replaced JLIcon (and unwanted React sub-dep) in rendermime-interfaces improved accuracy of IFileType.iconRenderer typing use render method for listings icons, simplify iconRenderer typing integrity delinted initital stab at minimal IJLIcon interface bugfix full revert of rendermime-interfaces; totally removed iconRenderer added namespacing to the JLIcon name prop type cleanup fixed unittests to deal with icon namespacing refined handling of icon container className attempt to fix lint-staged for both win and mac added `icon: string | {name: string, svgstr: string}` field added JLIcon.resolve static method added complete implementation of dynamic icon svg replacement split out JLIcon.IRenderer from JLIcon fixed up FileType handling to match new icon stuff removed icon backwards compatibility shim from filebrowser listing some type fixes small cleanup of vega icon svg fixed up typings related to JLIcon.IRenderer; added lots of docstrings untangled IFileType vs FileType mess in DocumentRegistry picked lint `IFileType.icon` now working in rendermime-interfaces; added index.ts to src/style subpkg of ui-components fixed external import of exports from src/style in ui-components pkg added render-related fields to `IFileType.icon` interface removed outdated IconRegistry based stories added stories based on new JLIcon icons cleanup for new story cleanup of interfaces/types and related docstrings bugfix to Renderer constructor signature typing use full icon implementation for `.icon` field in docregistry added icon upconversion to rendermime plugin creation routine removed DocumentRegistry.FileType and reverts all usages to IFileType bind passed render/unrender funcs in JLIcon constructor minor cleanup of ensureUiComponents func change all refs to iconRenderer => icon across codebase fixed handling of compolex cases in JLIcon.resolve and .constructor fixed up signature of IRenderer.render, can now flexibly take options bugfix refactored all refs JLIcon => LabIcon; still need to move jlicon.tsx finished JLIcon => LabIcon refactor by moving jlicon.tsx => labicon.tsx added functions to help render icon-as-css-background nodes added a `LabIcon` user guide bugfix (for code) and formatting fix (for docs) added resolveElement and resolveReact static methods to LabIcon fixed resolveX methods; removed getElement, marked getReact => UNSTABLE added the jupyter.lab.setting-icon field fixed up and simplified item icon handling in filebrowser listing removed UNSTABLE_getReact from settingeditor fixed wrong casing in icon name "textEditor" => "text-editor" bugfix; was passing extraneous props into LabIcon.resolveX methods iconClass => iconName conversion shim mostly removed; one special case adding optional fallback arg to LabIcon.resolveX methods added in test-ui-components, build broken, need to fix bugfix implemented fallback arg for LabIcon.resolveX methods README now has just user docs; all dev docs now in CONTRIBUTING iconStyle no longer exported; exposed LabIcon.UNSTABLE_style to replace removed last vestige of iconClass => icon name shim, with one exception added first actual unittest to test-ui-components integrity removed stranded `if (icon)` statement better test icons for test-ui-components, care of @tgeorgeux alphabetized existing extension point docs added Icon section to extension points docs added note/link about LabIcon to extension migration docs fixed typing error wrt latest lumino; removed unsafe widening of IRenderer followup #7767: small bugfix to lookup in UNSTABLE_getReact ensures that 'shift tab' => dedent shortcut works in text editor fixed react icon for vdom filetype migrated commands/menu items in filebrowser-extension to LabIcon integrity filebrowser-extension: all icons now LabIcon, .iconRenderer => .icon notebook-extension: all icons now LabIcon, .iconRenderer => .icon terminal-extension: all icons now LabIcon, .iconRenderer => .icon migrated all refs to deprecated title.iconRenderer => title.icon add LabIcon.renderer method to allow for binding props/styles to icons removes all uses of LabIcon.UNSTABLE_style from shell.ts refactored renderer => bindprops bindprops partially working LabIcon.bindprops now works as intended added styling for filebrowser context menu item icons all filebrowser context menu item icons now migrated => LabIcon. fixed use of addIcon fixed replace toggle button icon in find/replace widget fixed all launcher icons; removed all UNSTABLE methods from LabIcon removed Private.nameToClassName from labicon.tsx simplified icon resolvability check added temp fix (until lumino 2.0) for getting iconClass from a command finished audit of all uses of `iconClass` in jlab core src starting to fix menu icons integrity fixed menu item check marks. all menu icon issues fixed bugfix for disabled submenu caret. Some submenu icons not working added MenuSvg.insertItem hack to workaround submenu renderer issue fixed check mark icons in CommandPaletteSvg CommandPalette header icon mostly fixed, some minor styling bugs remain fixed styling for CommandPalette header icon created/added clearIcon integrity grouped Widget subclasses tweaked for svg icons into `widgets` subpkg bumped lumino deps to latest, needed for icon/virtualdom fixes fixed icon kind docstrings cleaned up icon styling system plugged new icon styling system into the rest of the program fixes for/streamling of icon style merging fix to statusBar icon style; removed default elementPosition deprecated `justify` => `elementPosition` across codebase implemented `elementSize` icon styling arg massive fixup of icon styling-related docstrings moved currently unused Renderers into Private namespace deprecated/replaced `kind` => `stylesheet` across codebase fix for small regression in settings editor icon style/spacing remove deprecated `rendererClass` from LabIcon.IOptions critical bugfix to icon style caching audited icon css across the codebase added `cleansvg` script; cleaned filetype icon svgs all icons now have a default width/height, 24x24 for most of them improved cleansvg cmd; cleansvg is now idempotent wrt all filetype svgs added full svgo.yaml config; now removes unknowns but still keeps defaults size default sizing of most icons to `width="16"` avoid clobbering palette icon stylesheet fixed launcher card icons for cmds with `iconClass` set fixed CSS for all uses of iconClass fix to fill of blueprint icons fixed legacy icon support for main/sidebar tabs, settings, and menus tgeorgeux (4): Added a better command palette icon added hover characteristics to some buttons updated property inspector icon Removed path fill to fix issue with icon rendering wrong in dark mode.
Description
With
jupyterlab-git
installed all entries in the file browser are empty (but they are still there and clickable, just... empty...). It's still possible to navigate (though you can't really tell where you're going) and opening files, and when changing directory the current path is shown correctly.Reproduce
Expected behavior
File browser entries with name, icon and size.
Context
Command Line Output
Browser Output
Plenty of these:The text was updated successfully, but these errors were encountered: