From 09684ee22bcf074ce01f3f48b69f55a5887e1ba6 Mon Sep 17 00:00:00 2001 From: Andrew Schlaepfer Date: Tue, 23 Apr 2019 17:15:19 -0700 Subject: [PATCH] fix re-focus on ctrl+f when search overlay is already open --- packages/documentsearch/src/searchinstance.ts | 2 ++ packages/documentsearch/src/searchoverlay.tsx | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/documentsearch/src/searchinstance.ts b/packages/documentsearch/src/searchinstance.ts index 9f2f816d534c..b9a669df99fb 100644 --- a/packages/documentsearch/src/searchinstance.ts +++ b/packages/documentsearch/src/searchinstance.ts @@ -67,9 +67,11 @@ export class SearchInstance implements IDisposable { */ focusInput(): void { this._displayState.forceFocus = true; + this._displayState.searchInputFocused = true; // Trigger a rerender without resetting the forceFocus. this._displayUpdateSignal.emit(this._displayState); + this._displayState.forceFocus = false; } /** diff --git a/packages/documentsearch/src/searchoverlay.tsx b/packages/documentsearch/src/searchoverlay.tsx index 28517ca3cf69..078d1d5c1a1d 100644 --- a/packages/documentsearch/src/searchoverlay.tsx +++ b/packages/documentsearch/src/searchoverlay.tsx @@ -73,7 +73,7 @@ class SearchEntry extends React.Component { } componentDidUpdate() { - if (this.props.forceFocus && this.props.inputFocused) { + if (this.props.forceFocus) { this.focusInput(); } }