From 5067aed922d698663074e113b44ea7119b36662f Mon Sep 17 00:00:00 2001 From: markellekelly Date: Sat, 7 Dec 2019 10:46:12 -0800 Subject: [PATCH] fixed readmes, final code cleaning --- packages/celltags-extension/README.md | 5 +++-- packages/celltags/README.md | 5 +++-- packages/celltags/src/addwidget.ts | 4 ---- packages/celltags/src/tool.ts | 2 +- packages/celltags/src/widget.ts | 14 ++++---------- 5 files changed, 11 insertions(+), 19 deletions(-) diff --git a/packages/celltags-extension/README.md b/packages/celltags-extension/README.md index 2d45e2131d85..7a2c75e70730 100644 --- a/packages/celltags-extension/README.md +++ b/packages/celltags-extension/README.md @@ -1,3 +1,4 @@ -# celltags +# @jupyterlab/celltags-extension -A refactor of jupyterlab-celltags intended to be merged into core. +A JupyterLab extension which provides an entry point for +[@jupyterlab/celltags](../celltags). diff --git a/packages/celltags/README.md b/packages/celltags/README.md index 2d45e2131d85..52550c724dd1 100644 --- a/packages/celltags/README.md +++ b/packages/celltags/README.md @@ -1,3 +1,4 @@ -# celltags +# @jupyterlab/celltags -A refactor of jupyterlab-celltags intended to be merged into core. +A JupyterLab package which provides an interface for viewing and manipulating +descriptive tags in notebook cell metadata. diff --git a/packages/celltags/src/addwidget.ts b/packages/celltags/src/addwidget.ts index 3088b5afdae1..a8ae0e6b9dcc 100644 --- a/packages/celltags/src/addwidget.ts +++ b/packages/celltags/src/addwidget.ts @@ -118,8 +118,6 @@ export class AddWidget extends Widget { /** * Handle the `'focus'` event for the input box. - * - * @param event - The DOM event sent to the widget */ private _evtFocus() { if (!this.editing) { @@ -151,8 +149,6 @@ export class AddWidget extends Widget { /** * Handle the `'focusout'` event for the input box. - * - * @param event - The DOM event sent to the widget */ private _evtBlur() { if (this.editing) { diff --git a/packages/celltags/src/tool.ts b/packages/celltags/src/tool.ts index 03ba10778423..d9a797a6d35f 100644 --- a/packages/celltags/src/tool.ts +++ b/packages/celltags/src/tool.ts @@ -247,7 +247,7 @@ export class TagTool extends NotebookTools.Tool { this.validateTags(this.tracker.activeCell, taglist); } + public tracker: INotebookTracker = null; private tagList: string[] = []; private header: boolean = false; - public tracker: INotebookTracker = null; } diff --git a/packages/celltags/src/widget.ts b/packages/celltags/src/widget.ts index 434c12658793..1f8709933c43 100644 --- a/packages/celltags/src/widget.ts +++ b/packages/celltags/src/widget.ts @@ -83,10 +83,10 @@ export class TagWidget extends Widget { this._evtClick(); break; case 'mouseover': - this._evtMouseOver(event as MouseEvent); + this._evtMouseOver(); break; case 'mouseout': - this._evtMouseOut(event as MouseEvent); + this._evtMouseOut(); break; default: break; @@ -123,8 +123,6 @@ export class TagWidget extends Widget { /** * Handle the `'click'` event for the widget. - * - * @param event - The DOM event sent to the widget */ private _evtClick() { if (this.applied) { @@ -137,19 +135,15 @@ export class TagWidget extends Widget { /** * Handle the `'mouseover'` event for the widget. - * - * @param event - The DOM event sent to the widget */ - private _evtMouseOver(event: MouseEvent) { + private _evtMouseOver() { (this.node as HTMLElement).classList.add('tag-hover'); } /** * Handle the `'mouseout'` event for the widget. - * - * @param event - The DOM event sent to the widget */ - private _evtMouseOut(event: MouseEvent) { + private _evtMouseOut() { (this.node as HTMLElement).classList.remove('tag-hover'); }