From fd28d0a122df212a10dd2ef5721473cf1e54dc87 Mon Sep 17 00:00:00 2001 From: Dominik Moritz Date: Tue, 16 Jul 2019 12:44:31 +0200 Subject: [PATCH] Finalize Vega view before creating a new one --- packages/vega4-extension/src/index.ts | 4 ++++ packages/vega5-extension/src/index.ts | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/packages/vega4-extension/src/index.ts b/packages/vega4-extension/src/index.ts index 3ab4401e88da..26de8fb4930d 100644 --- a/packages/vega4-extension/src/index.ts +++ b/packages/vega4-extension/src/index.ts @@ -85,6 +85,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer { this.node.textContent = ''; this.node.appendChild(el); + if (this._result) { + this._result.view.finalize(); + } + this._result = await vega.default(el, spec, { actions: true, defaultStyle: true, diff --git a/packages/vega5-extension/src/index.ts b/packages/vega5-extension/src/index.ts index 5e5634c93a05..d9bd96b5a313 100644 --- a/packages/vega5-extension/src/index.ts +++ b/packages/vega5-extension/src/index.ts @@ -85,6 +85,10 @@ export class RenderedVega extends Widget implements IRenderMime.IRenderer { this.node.textContent = ''; this.node.appendChild(el); + if (this._result) { + this._result.view.finalize(); + } + this._result = await vega.default(el, spec, { actions: true, defaultStyle: true,