From a41bdce986a1cf620f08637e5a9321b144406302 Mon Sep 17 00:00:00 2001 From: Zerline Date: Tue, 4 Jun 2019 16:58:00 +0200 Subject: [PATCH 1/3] SVG namespace. Fixes #6295. --- packages/rendermime/src/renderers.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/rendermime/src/renderers.ts b/packages/rendermime/src/renderers.ts index 8df3a450ba6f..cf1de663231f 100644 --- a/packages/rendermime/src/renderers.ts +++ b/packages/rendermime/src/renderers.ts @@ -418,6 +418,12 @@ export function renderSVG(options: renderSVG.IRenderOptions): Promise { return Promise.resolve(undefined); } + // Add missing SVG namespace (if actually missing) + var patt = ']+xmlns=[^>]+svg'; + if (source.search(patt) < 0) { + source = source.replace(' Date: Tue, 4 Jun 2019 18:32:08 +0200 Subject: [PATCH 2/3] Fixed the corresponding test. --- tests/test-rendermime/src/factories.spec.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test-rendermime/src/factories.spec.ts b/tests/test-rendermime/src/factories.spec.ts index b2f8e5d4e9dc..fc0b920ef8da 100644 --- a/tests/test-rendermime/src/factories.spec.ts +++ b/tests/test-rendermime/src/factories.spec.ts @@ -135,6 +135,7 @@ describe('rendermime/factories', () => { describe('#createRenderer()', () => { it('should create an img element with the uri encoded svg inline', async () => { const source = ''; + const displaySource = ''; const f = svgRendererFactory; const mimeType = 'image/svg+xml'; const model = createModel(mimeType, source, true); @@ -142,7 +143,7 @@ describe('rendermime/factories', () => { await w.renderModel(model); const imgEl = w.node.getElementsByTagName('img')[0]; expect(imgEl).to.be.ok; - expect(imgEl.src).to.contain(encodeURIComponent(source)); + expect(imgEl.src).to.contain(encodeURIComponent(displaySource)); }); }); }); From 877075b5d38d502a54fa796f039b7a51db8ab508 Mon Sep 17 00:00:00 2001 From: Zerline Date: Wed, 5 Jun 2019 11:13:08 +0200 Subject: [PATCH 3/3] Fixed keyword name. --- packages/rendermime/src/renderers.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rendermime/src/renderers.ts b/packages/rendermime/src/renderers.ts index cf1de663231f..8a684159be82 100644 --- a/packages/rendermime/src/renderers.ts +++ b/packages/rendermime/src/renderers.ts @@ -419,7 +419,7 @@ export function renderSVG(options: renderSVG.IRenderOptions): Promise { } // Add missing SVG namespace (if actually missing) - var patt = ']+xmlns=[^>]+svg'; + let patt = ']+xmlns=[^>]+svg'; if (source.search(patt) < 0) { source = source.replace('