You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the package name is defined in setup.py as name = juopyterlab-something, the upgrade_extension.py appears to change the package name to name = juopyterlab_something (- --> _) in pyproject.toml.
I think the name should be the same as the name previously defined in setup.py.
Will not this cause any problems?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
If the package name is defined in setup.py as
name = juopyterlab-something
, the upgrade_extension.py appears to change the package name toname = juopyterlab_something
(-
-->_
) in pyproject.toml.I think the name should be the same as the name previously defined in setup.py.
Will not this cause any problems?
upgrade_extension.py
jupyterlab/jupyterlab/upgrade_extension.py
Line 111 in ea6dd41
template/pyproject.toml.jinja
https://github.com/jupyterlab/extension-template/blob/fcd01842647ba08a29512c940010b4938ba65600/template/pyproject.toml.jinja#L6
Beta Was this translation helpful? Give feedback.
All reactions