Allow pasting text in terminal with CTRL-V

[timothyclemansinsea]

No description provided.

[blink1073]

Dev note: I couldn't get xterm.js to install on Windows 7 or 10 to try this out. I think it will require starting JupyterLab on a POSIX machine and logging in from a Windows machine to debug.

[blink1073]

I was able to reproduce this by running jupyter lab --ip=0.0.0.0 and following these instructions to log in from my Windows 10 VM. Ctrl+Shift+V works for paste but not Ctrl+V. I am going to push this one to 1.0 since it may require changes to xterm.js to get it working.

[blink1073]

I verified that this is also a problem with the classic notebook, which means it is not a result of any keyboard shortcut handling on the part of JupyterLab.

[brylie]

CTRL-V pasting doesn't work for me in Kubuntu 17.04 + Firefox 55. Related issue or should I open a separate issue?

[blink1073]

@brylie, I think that is the same issue.

[brylie]

Cool. Should we rename the issue to something like "Allow pasting text in terminal with CTRL-V"?

[blink1073]

Good call @brylie, updated.

[blink1073]

Dev note, this is possible using attachCustomKeyEventHandler. For Ctrl+C we can prevent the xterm default if there is selected text and instead put the text on the system clipboard. For Ctrl+V we always prevent the xterm default and let the browser fire a paste event.

[jasongrout]

Does Ctrl+V usually paste into a normal terminal? I thought you had to use Ctrl+Shift+V to paste into terminals. (I'm on a mac now, which always works with Command+V, so I can't test.)

[jasongrout]

For example, https://askubuntu.com/questions/823883/ctrl-v-ctrl-c-in-terminal, https://stackoverflow.com/questions/7123709/how-to-paste-into-a-terminal, https://howtoubuntu.org/how-to-cut-copy-and-paste-in-the-terminal-in-ubuntu, etc. say to use Ctrl+Shift+V for terminals.

[t-makaro]

ctrl+c and ctrl+v work in both cmd and powershell on windows 10, and I can confirm that it does work with powershell open in jlab on windows 10 just fine (didn't test with cmd in jlab).

[jasongrout]

According to #1146 (comment), the copy/paste commands depend on what we are connected to, which seems consistent with what is reported here.

[jasongrout]

I suggest we close this issue in favor of #1146, and we make #1146 about adding documentation to explain the various copy/paste shortcuts in the different systems. Thoughts? @blink1073?