Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A checklist to see what features have already been implemented in JupyterLab notebook #1287

Closed
Analect opened this issue Nov 23, 2016 · 8 comments
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@Analect
Copy link

Analect commented Nov 23, 2016

On @blink1073 suggestion over here.

I'm testing jupyterlab within jupyterhub and have a development version (master) of the notebook running within jupyterlab.

I was trying to get markdown cell attachments (an embedded image) working, but it turns out it hasn't yet been implemented in the notebook within jupyterlab. It's also not possible to edit cell meta-data from within the notebook. Meanwhile, other functionality like cell drag/drop and multi-cell selection is working.

It would be great to have a checklist somewhere of what aspects of notebook classic have been implemented within the notebook on jupyterlab. I realise jupyterlab is still alpha and that a stated objective of jupyterlab is to achieve parity with the classic version before shifting to beta/1.0 status. I'm also aware of the general roadmap here, but the check-list I'm suggesting would be at a more granular level below this, perhaps.

@blink1073 blink1073 added this to the Beta milestone Nov 23, 2016
@blink1073
Copy link
Member

Thanks for following up, @Analect!

@jasongrout
Copy link
Contributor

I think at this point, it would be easier to list the features not implemented yet, as separate issues, with the cat:Feature Parity and component:Notebook tags. That way the list is automatically kept up to date as we implement things and close the relevant issues: https://github.com/jupyterlab/jupyterlab/issues?q=is%3Aopen+is%3Aissue+label%3A%22cat%3AFeature+Parity%22+label%3Acomponent%3ANotebook

What do you think?

@blink1073
Copy link
Member

That sounds good, as a link in the roadmap.

@jasongrout
Copy link
Contributor

jasongrout commented Nov 24, 2016

+1. How about we settle this issue with a link in the roadmap to the query, and an invitation to submit an issue if you see something that is lacking.

@Analect
Copy link
Author

Analect commented Nov 25, 2016

Thanks @blink1073 @jasongrout
I suppose your approach of labeling outstanding issues could work, but it presumes that someone knows what's missing and has gone to the trouble of generating an appropriate issue. I don't know the Jupyter code-base well enough to figure that out, but would be prepared to help if someone pointed me in the right direction.

There's a pre-existing issue pertaining to a cell tool-bar here. I'm not sure whether or not that generically covers my use-cases:
a. to get markdown cell attachments (an embedded image) working within notebook on jupyterlab
b. a means of viewing/editing custom meta-data on a cell as referenced here.

I can add these as separate issues, if you think that's advisable, although I don't think I have an ability to set labels.

@blink1073
Copy link
Member

We had previously attempted to manually curate a feature parity list in jupyter/jupyter-js-notebook#87, but checklists in github issues as well as lists in wiki pages get out of date and sync very quickly.

It is unfortunate that you can't add labels to your own issues, but we have been doing a fairly good job of adding and using the labels consistently as a team.

I think with the right messaging on the roadmap and perhaps as part of an issue template like "please add this as a notebook feature parity issue" would go a long way.

@blink1073
Copy link
Member

I've updated the roadmap in jupyter/roadmap#33 and made sure we've captured all of the existing feature parity issues, and calling this one addressed. Please feel free to reopen if you disagree, @Analect.

@Analect
Copy link
Author

Analect commented Dec 8, 2016

Thanks @blink1073 . Much appreciated.
I added #1398 ... which I don't think was being captured elsewhere ... although it may overlap with other issues that may tackle broad cell-based UI issues ... feel free to remove if you think it's captured elsewhere.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

3 participants