New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the default filebrowser drive configurable #16099
Comments
Thanks @martinRenou, I can work on this early next week and aim to get a draft PR by the next JupyterLab meeting. |
I thinking making the core file browser drive configurable is not enough here. If we only make the file browser plugin configurable here, the e.g. Running Tab plugin will point to different paths than the file browser. Ideally, for the core application to feel self-consistent, we want all references to contents to be consistent unless explicitly asked to fetch from another drive. Alll plugins should be able to assume that they are pulling from the same drive by default. Instead of just changing the file browser, I would propose that we make the defaultDrive in the ContentsManager API configurable by outside plugins. I also think we should give the Jupyter Server REST API drive a fixed name, e.g. |
Really, this is a question about implicit versus explicit reference of the drive. How do we build a self-consistent core application where we can allow folks to build off of the core contents provider without fear that things will break when say RTC is enabled? What I found tricky when thinking about all the implications here is that Jupyter collaboration is kind of a special case. The This differs from, say, jupyterlab-github's drive, |
The root issue here is that the Jupyter Server REST APIs do not understand drive prefixes. So the implicit versus explicit problem is really about what path the Jupyter Server can speak. Jupyter collaboration breaks things because it uses path prefixes that cause weird things to happen on the server. For example, the Jupyter session database will have references to notebook paths that the server doesn't understand, thus, jumbling the "Running" tab in JupyterLab. Another example of an issue is that Jupyter collaboration uses the file ID extension to store unique IDs for all notebook paths. When RTC is enabled, you'll begin to see two UUIDs for each notebook, one for the |
Indeed 👍🏽 totally agree with this, I found out later there was a Concerning the drive prefix, I assumed the default one was not using a prefix? So if we are able to overwrite the default drive in the case of collaboration, we can probably get rid of the |
cc. @davidbrochart @ellisonbg @Zsailer @SylvainCorlay @jtpio
Problem
Currently, the default file browser does not allow overwriting the default drive.
This makes it difficult to overwrite the behavior of the default filebrowser:
RTC:
and overwrite the default filebrowser to use it, this has its load of issues. Being able to overwrite the default drive would probably be less problematic.Proposed Solution
I would like to suggest that JupyterLab allow overwriting the default drive.
The text was updated successfully, but these errors were encountered: