Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The bot does not update snapshots in examples #16183

Open
krassowski opened this issue Apr 17, 2024 · 3 comments
Open

The bot does not update snapshots in examples #16183

krassowski opened this issue Apr 17, 2024 · 3 comments

Comments

@krassowski
Copy link
Member

The bot does not update playwright snapshots used in examples; this adds to the workload when making changes with visual impact on the interface.

For example this had an impact on PRs #16142 and #15948.

We should consider adding a new job in the workflow triggered on comment asking the bot to update snapshots:

jobs:
update-galata-snapshots:

@fcollonval
Copy link
Member

Information for the interested contributor, this is gonna be tricky because example tests are not regular Playwright tests. They imply the creation of a dummy package in which we copy the test file and the reference snapshots, execute the test and finally copy back the test results:

async def run_browser(url):

@jtpio
Copy link
Member

jtpio commented May 1, 2024

example tests are not regular Playwright tests

Could they be converted to regular Playwright tests, if that can ease maintenance and align with the rest of the code base?

@fcollonval
Copy link
Member

Could they be converted to regular Playwright tests, if that can ease maintenance and align with the rest of the code base?

Probably, the main technical difficulty is that the current script is dealing with the server application being specific for each example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants