Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The filebrowser "Last Modified" column in narrow mode is not covered by tests #16192

Open
krassowski opened this issue Apr 18, 2024 · 0 comments
Open

The filebrowser "Last Modified" column in narrow mode is not covered by tests #16192

krassowski opened this issue Apr 18, 2024 · 0 comments
Labels
maintenance pkg:filebrowser tag:Testing

Comments

@krassowski
Copy link
Member

Description

#15948 added narrow and short and a new renderer method updateItemModified.

There are no tests to cover the display of the "Last Modified" column in narrow modes nor that method (or actually renderer in general). The transition between modes is not covered by tests - an integration test capturing snapshots after resizing sidebar in steps would be great here.

Context

  • JupyterLab version: 4.2.0b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance pkg:filebrowser tag:Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krassowski @JasonWeill