Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation wrapper is missing around debugger filter box #16220

Closed
krassowski opened this issue Apr 22, 2024 · 1 comment
Closed

Translation wrapper is missing around debugger filter box #16220

krassowski opened this issue Apr 22, 2024 · 1 comment
Labels
bug good first issue
Milestone
4.2.0

Comments

@krassowski
Copy link
Member

Description

The placeholder is not translated:

jupyterlab/packages/debugger/src/panels/kernelSources/filter.tsx

Line 27 in 8819549

placeholder="Filter the kernel sources"

See: https://jupyterlab.readthedocs.io/en/stable/extension/internationalization.html
@krassowski krassowski added bug good first issue status:Needs Triage Applied to new issues that need triage labels Apr 22, 2024
@krassowski krassowski added this to the 4.2.0 milestone Apr 22, 2024
@itsmevichu itsmevichu mentioned this issue Apr 22, 2024
Merged
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Apr 23, 2024
@JasonWeill JasonWeill mentioned this issue Apr 23, 2024
Open
@fcollonval
Copy link
Member

Closed by #16224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
4.2.0
Development

No branches or pull requests
3 participants
@krassowski @fcollonval @JasonWeill