Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to select the path in debugger source component #16246

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow to select the path in debugger source component #16246

wants to merge 2 commits into from

Conversation

krassowski
Copy link
Member

References

Fixes #16235

Code changes

  1. Make the source path user-selectable
  2. Do not open the read-only editor on click as it steals focus and removes selection; instead make it open on Ctrl + click

User-facing changes

Clicking on the source path now allows selection and thus copying the file

image

Ctrl + click will open the main area widget:

image

Note: user can still click on the button next to the path to open the source without holding Ctrl:

image

Backwards-incompatible changes

None

@jupyterlab-probot jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@github-actions github-actions bot added tag:CSS For general CSS related issues and pecadilloes pkg:debugger Design System CSS labels Apr 26, 2024
@jtpio jtpio added this to the 4.3.0 milestone May 1, 2024
@jtpio
Copy link
Member

jtpio commented May 1, 2024

Adding to 4.3.0 since it's tagged as enhancement

jtpio
jtpio approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, diff looks good!

Waiting for the CI to be done. Maybe some snapshots will need to be updated?

@krassowski
Copy link
Member Author

Looks like its passing after restart :) Let's hold of with merging here until we release 4.2.0 (today!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtpio jtpio jtpio approved these changes

Assignees

@krassowski krassowski

Labels
Design System CSS enhancement pkg:debugger tag:CSS For general CSS related issues and pecadilloes
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Debugger: Unable to Copy/Paste Paths
2 participants
@krassowski @jtpio