Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Modified" header moves sort caret icon to next line if sidebar is narrow #16239

Open
krassowski opened this issue Apr 25, 2024 · 2 comments

Comments

@krassowski
Copy link
Member

krassowski commented Apr 25, 2024

Description

image

Reproduce

  1. Sort by modified
  2. Resize the sidebar in 4.2.0b3

Expected behavior

image

Context

  • JupyterLab version: 4.2.0b3
@krassowski krassowski added bug status:Needs Triage Applied to new issues that need triage labels Apr 25, 2024
@krassowski
Copy link
Member Author

issue

With #16207:

v2

There are two options:

  • have a third state, the earlier proposed "Mod." for the most narrow option (and delete the ... "too narrow" indicator logic)
  • change the "too narrow" indicator logic to kick in eariler

CC @JasonWeill

@krassowski
Copy link
Member Author

This also looks bad when there is an extra column.

image

I think we need a more generic logic on minimum width of each column and to allow each column to change size separately.

@JasonWeill JasonWeill added pkg:filebrowser and removed status:Needs Triage Applied to new issues that need triage labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants