Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search highlight does not move to next cell when replacing a with aa #16242

Closed
krassowski opened this issue Apr 25, 2024 · 1 comment · Fixed by #16258
Closed

Search highlight does not move to next cell when replacing a with aa #16242

krassowski opened this issue Apr 25, 2024 · 1 comment · Fixed by #16258
Labels
bug tag:Search and Replace

Comments

@krassowski
Copy link
Member

Description

Even after #15881

Reproduce

tricky

Expected behavior

Moves between cells

Context

  • JupyterLab version: 4.2.0rc0
@krassowski krassowski added bug tag:Search and Replace status:Needs Triage Applied to new issues that need triage labels Apr 25, 2024
@krassowski krassowski mentioned this issue Apr 25, 2024
Merged
@JasonWeill
Copy link
Contributor

I can reproduce this. #15881 fixed the issue where the replacement text matches the source text, but not where the replacement text matches the source text twice. 🤦

@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Apr 26, 2024
@JasonWeill JasonWeill mentioned this issue Apr 26, 2024
Merged
@JasonWeill JasonWeill mentioned this issue May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug tag:Search and Replace
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix replace when replacement text matches source text multiple times JasonWeill/jupyterlab
2 participants
@krassowski @JasonWeill