Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeller no longer removes outdated labels from PRs #16256

Closed
krassowski opened this issue Apr 26, 2024 · 0 comments · Fixed by #16257
Closed

Labeller no longer removes outdated labels from PRs #16256

krassowski opened this issue Apr 26, 2024 · 0 comments · Fixed by #16257

Comments

@krassowski
Copy link
Member

As noted in #16228 (comment) the labeller did not remove labels which are no longer needed. I also saw that recently @JasonWeill had to manually remove dozens of labels on #16207.

This was not the case previously. It appears to be the result of a recent upgrade to labeller action v5 which fixed a bug in sync-labels setting. Namely, prior to v5 the default was de-facto "true" (it was false it was incorrectly parsed to true).

I think the old behaviour was better.

@krassowski krassowski added maintenance status:Needs Triage Applied to new issues that need triage labels Apr 26, 2024
@JasonWeill JasonWeill removed the status:Needs Triage Applied to new issues that need triage label Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants