Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command currentLineWrap is always disabled while currentLineNumbers works well #16259

Open
MRYingLEE opened this issue Apr 27, 2024 · 1 comment
Labels

Comments

@MRYingLEE
Copy link

MRYingLEE commented Apr 27, 2024

Command currentLineWrap is always disabled while currentLineNumbers works well.

These 2 commands should have the same code structure. So I checked the source code and found unexpected difference.

In the currentLineWrap,(

(widget?.content.editor.getOption('lineWrap') as boolean) ?? false
)
isToggled: () => { const widget = tracker.currentWidget; return ( (widget?.content.editor.getOption('lineWrap') as boolean) ?? false ); }

While in the currentLineNumbers,
(

(widget?.content.editor.getOption('lineNumbers') as
| boolean
| undefined) ?? false
);
)
isToggled: () => { const widget = tracker.currentWidget; return ( (widget?.content.editor.getOption('lineNumbers') as | boolean | undefined) ?? false ); }

I believe there is a bug in the code of currentLineWrap, which should follow the way of currentLineNumbers.

Please give a quick fix.
Thanks,

@MRYingLEE MRYingLEE added the bug label Apr 27, 2024
@jupyterlab-probot jupyterlab-probot bot added the status:Needs Triage Applied to new issues that need triage label Apr 27, 2024
Copy link

welcome bot commented Apr 27, 2024

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants