Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Shift + Tab contextual help inspector tooltip regression #16343

Merged
merged 2 commits into from
May 22, 2024

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented May 18, 2024

References

Fixes #16319

Code changes

  • adds an integration test case
  • fixes the issue by not preventing default (i.e. not returning true) in the dedentIfNotLaunchingTooltip handler

User-facing changes

Shift + Tab works again

Backwards-incompatible changes

None

@krassowski krassowski added the bug label May 18, 2024
@krassowski krassowski added this to the 4.2.x milestone May 18, 2024
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski marked this pull request as ready for review May 18, 2024 20:53
@krassowski krassowski marked this pull request as draft May 19, 2024 07:56
that the default is not prevented and tooltip can be shown
@krassowski krassowski marked this pull request as ready for review May 19, 2024 11:03
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krassowski

@krassowski krassowski merged commit 4e0cbc0 into jupyterlab:main May 22, 2024
83 checks passed
@krassowski
Copy link
Member Author

@meeseeksdev please backport to 4.2.x

meeseeksmachine pushed a commit to meeseeksmachine/jupyterlab that referenced this pull request May 22, 2024
krassowski added a commit that referenced this pull request May 22, 2024
…ip regression (#16360)

Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shift + tab does not open inspector tooltip on 4.2.0
2 participants