Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a json editor #451

Closed
jasongrout opened this issue Jul 19, 2016 · 8 comments · Fixed by #6349
Closed

Add a json editor #451

jasongrout opened this issue Jul 19, 2016 · 8 comments · Fixed by #6349
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Extension Idea Ideas for interesting extensions that live outside of JupyterLab core.
Milestone

Comments

@jasongrout
Copy link
Contributor

This looks promising: https://github.com/josdejong/jsoneditor

@eskirk
Copy link
Contributor

eskirk commented Jul 20, 2016

@jasongrout I'm gunna check this out, seems simple enough
the only thing is, the typed file seems outdated (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/jsoneditoronline/jsoneditoronline.d.ts).
Should it still work even though the repo has been renamed/moved?

@jasongrout
Copy link
Contributor Author

I'm not sure if the typing file still works, though it shouldn't depend on the repo location.

I'd say this is probably lower priority than #472, though.

@jasongrout jasongrout added this to the 2.0 milestone Jul 20, 2016
@ellisonbg ellisonbg modified the milestones: Backlog, 2.0 Oct 13, 2016
@xtrntr
Copy link

xtrntr commented Nov 23, 2016

This looks interesting, but i'm not quite entirely sure how and where a JSON editor is going to fit in.

@jasongrout
Copy link
Contributor Author

I think @gnestor worked on this. Grant, can you comment?

@gnestor
Copy link
Contributor

gnestor commented Nov 23, 2016

https://github.com/jupyterlab/jupyterlab_json is currently working for viewing JSON (not editing). I've managed to integrate https://github.com/gnestor/notebook_json into the same Python package, so after I publish to PyPI, a user should be able to pip install jupyterlab_json (or pip install jupyter_json?) and install extensionsfor both notebook and lab. I like the idea of a JSON editor but I'd like to hear more about how it might be used vs. using a text editor.

@jasongrout jasongrout modified the milestone: Future Sep 5, 2018
@jasongrout jasongrout added the tag:Extension Idea Ideas for interesting extensions that live outside of JupyterLab core. label Apr 10, 2019
@cocoaaa
Copy link

cocoaaa commented May 10, 2019

Currently, it seems .geojson files are not recognized as json-like format in the editor. It would be nice if the editor does so:
image

@gnestor
Copy link
Contributor

gnestor commented May 10, 2019

Good catch @cocoaaa! It's an easy fix. I'll submit a PR 👍

@gnestor
Copy link
Contributor

gnestor commented May 14, 2019

#6349

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Extension Idea Ideas for interesting extensions that live outside of JupyterLab core.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants