Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.35 #5384

Closed
31 tasks done
blink1073 opened this issue Sep 26, 2018 · 24 comments
Closed
31 tasks done

Release 0.35 #5384

blink1073 opened this issue Sep 26, 2018 · 24 comments
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@blink1073
Copy link
Member

blink1073 commented Sep 26, 2018

We plan to release 0.35rc on Friday 28 September, Final on Friday 5 October.

Now do the actual final release:

  • Update jupyterlab/_version.py with a final version
  • Make a final Python release
  • Merge the PRs on the other repos and set the default branch of the
    xckd repo
  • Update the latest npm tags by running jlpm run update:dist-tags and running the commands it prints out
  • Publish to conda-forge (wait for the auto-bot)

After a few days (to allow for possible patch releases), set up development for
the next release:

  • Create a branch for the release and push to GitHub
  • Update jupyterlab/_version.py with a dev version
  • Run jlpm integrity to update the dev_mode version
  • Commit and push the version update to master
  • Release the other repos as appropriate
  • Update version for binder (see below)
@blink1073 blink1073 added this to the 0.35 milestone Sep 26, 2018
@dhirschfeld
Copy link
Member

Will this require that all extensions also be updated or will the currently published extensions continue to work with 0.35? If the former I might pin my JupyterLab until all the extensions have had time to make the necessary changes.

@jasongrout
Copy link
Contributor

jasongrout commented Sep 27, 2018

It depends on the extension. ipywidgets extensions (bqplot, ipyleaflet, ipyvolume, etc.) likely will continue to work. Rendermime extensions and theme extensions may continue to work. Extensions that depend on more core packages will likely need to be updated.

@blink1073
Copy link
Member Author

Initial hack at a change log (thanks @goanpeca and @ccordoba12!):

$ loghub jupyterlab/jupyterlab -m 0.35 -t $GITHUB_TOKEN

LOGHUB: Querying issues for milestone 0.35

###############################################################################

Version 0.35 (2018/09/28)

Issues Closed

In this release 5 issues were closed.

Pull Requests Merged

In this release 50 pull requests were closed.

###############################################################################

@ccordoba12
Copy link

It looks really nice! Glad to know you decided to use loghub to generate the Changelogs for JLab.

@blink1073
Copy link
Member Author

0.35.0rc2 is released. That was a battle. I switched laptops (and OSes) this week...

@jasongrout
Copy link
Contributor

Thank you!

@blink1073
Copy link
Member Author

Note to self, use this template (will be part of a follow-up PR with changes to the release instructions):

`v0.xx.0 <https://github.com/jupyterlab/jupyterlab/releases/tag/v0.xx.0>`__
---------------------------------------------------------------------------

{{ close_date }}
^^^^^^^^^^^^^^^

See the `JupyterLab
0.xx.0 <https://github.com/jupyterlab/jupyterlab/milestone/xx?closed=1>`__
milestone on GitHub for the full list of pull requests and issues closed.

{%   for pr in pull_requests -%}
* {{ pr['title']|title }} (`#{{ pr['number'] }} <{{pr['html_url']}}>`__)
{%   endfor %}

@jasongrout
Copy link
Contributor

From Gitter, about generating that issue list in markdown:

@blink1073
I posted the template and the invocation in the issue
Relies on pip install loghub
And assigning a GH token to $GH_TOKEN

@jasongrout
Copy link
Contributor

I added a tweaked version of that log template in #5417.

@jasongrout
Copy link
Contributor

There were lots of what seemed to be spurious build failures. So I merged in the PRs that seemed reasonable, and am now checking the tests on master.

@jasongrout
Copy link
Contributor

I just published the final js versions to npm under the next tag.

@jasongrout
Copy link
Contributor

Update: there's one PR open with xkcd tutorial update instructions, and another PR open to try to fix some of the travis errors we're seeing.

@blink1073
Copy link
Member Author

Update: 0.35 final is released on PyPI, conda-forge pending: conda-forge/jupyterlab-feedstock#143

@blink1073
Copy link
Member Author

Are we ready to complete this checklist with a 0.35.1 release that includes only #5445?

@blink1073
Copy link
Member Author

I plan to finish this up tomorrow morning with all PRs merged to 0.35 unless I hear otherwise.

@blink1073
Copy link
Member Author

I'm not able to release packages to npm on my machine do to an EPERM error. I'm at a loss about how to address it, tried several things. I might set up a VM tomorrow and try again.

@jasongrout
Copy link
Contributor

Weird. Do you want me to release the packages?

@blink1073
Copy link
Member Author

No, I'd like to see if I can do it using WSL, fun experiment. 😉

@blink1073
Copy link
Member Author

blink1073 commented Oct 12, 2018

npm packages are released, but I can't finish the 0.35.1 release until I switch to Linux. I give up trying to do OSS on Windows...

@vidartf
Copy link
Member

vidartf commented Oct 12, 2018

I give up trying to do OSS on Windows...

Catch 22: It's hard to do OSS on Windows because the OSS tools that you use doesn't work on Windows 😓

@blink1073
Copy link
Member Author

I tried really hard to use it for the past two weeks. I have spent the entire time fighting with the OS and accomplished hardly any work. Python development is reasonable, but until Microsoft steps in and helps with node development it is nigh impossible...

@dhirschfeld
Copy link
Member

As a Windows user that doesn't bode well! 😬

Any tips for what to watch out for / what doesn't work well?
I know I've found working on the frontend stuff a bit tough but I thought that was just my inexperience.

@blink1073
Copy link
Member Author

For daily usage, the only real show-stopper is the path length limitation, if you are using an administered computer and can't change the registry setting to remove the restriction. Here is a handy guide from Microsoft.

For JupyterLab maintenance, I was consistently bumping against the mishandling of symlinks.

About 5 years ago Microsoft stepped in and helped with the Windows build situation in Python, helping to decouple the Python version from the required MSVC runtime. I think a similar level of effort would be required to address these pain points.

@blink1073
Copy link
Member Author

All actions complete.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

5 participants