New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Phosphor tab dragging behavior #5406
Comments
Thank you @tgeorgeux and @Zsailer for working on this. We went over the main results this afternoon and it looks like there are some actions we will be able to take based on this. One though - maybe @tgeorgeux you can present this at the team meeting next Wednesday to bring other folks up to speed? That would be a good way to get into the question of implementation. |
I've had an open PR for this on phosphor for a while. |
For reference, the open PR in phosphor is phosphorjs/phosphor#365 I commented there on several ways to move forward with pushing these changes to a jlab prerelease. I think we really need to have a prerelease with these changes so that we can test them out a bit before a final 1.0 release. |
TODO:
|
This pulls in the tab drop zone change in @phosphor/widgets 1.7.0. Fixes jupyterlab#5406
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion. |
I wanted to bring attention to the issue I opened on the Phosphor repo about tab docking.
phosphorjs/phosphor#360
I am not 100% sure where the line is drawn between phosphor's and jupyterLab's execution of these so if I need to duplicate parts of this let me know please.
@Zsailer @jasongrout @afshin @blink1073 @saulshanabrook @ian-r-rose @sccolbert
Thanks everybody have a great weekend!
The text was updated successfully, but these errors were encountered: