Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Within cell search leads to confusion and accidental code deletion. #5411

Closed
mikemac8888 opened this issue Sep 30, 2018 · 1 comment
Closed
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@mikemac8888
Copy link

Describe the bug
The new within cell search changes default search behaviour existing in most document based programs including Jupyter Notebook. Now searching for multiple instances of the same symbol leads to accidental code deletion.

To Reproduce

  1. Press Apple + F to search for a symbol. For example "def".

  2. Press Enter first time. This finds the first instance of "def".

  3. Press Enter second time expecting to find next instance of "def". This deletes the first instance of "def" and adds a newline.

Additional notes

Most computer editing programs work from a document search perspective. I can't think of any that force search within a small section of a document. Thus the average user will be confused by this behaviour.

The option to press Apple + F twice is not an acceptable alternative. After months of using Jupyter Lab I still make this error daily.

Please provide an option to disable this within cell search mode.

Thanks

@blink1073
Copy link
Member

Hi @mikemac8888, we're tracking this in #1074, which I've just moved to the 1.0 milestone.

@blink1073 blink1073 added this to the Reference milestone Oct 4, 2018
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

2 participants