Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include specific versions of jlab packages in the yarn resolution key of package.json #5958

Closed
jasongrout opened this issue Feb 7, 2019 · 1 comment
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Contributor

jasongrout commented Feb 7, 2019

Especially with prerelease js packages, npm (and hence yarn) can end up with multiple versions of a package since the npm ^x.y.z does not include any packages on the next tag. We're seeing this in ipywidgets, where the base ipywidgets package can work with a number of jlab versions (including the prerelease version, but the yarn resolution algorithm doesn't count that prerelease when you have such a large range of acceptable versions), however in a prerelease we want to certainly pin the version to the prerelease js version.

So it may be useful to pin the versions of the js packages using the yarn resolution key in the staging (and dev-mode) package.json to be the exact version we want.

As a simplified example, the base widget package has a dependency on services 1||2||3||4.alpha.0, but that means the yarn resolution algorithm picks version 3 instead of version 4.alpha.0, since 3 is the latest tagged release.

@jasongrout jasongrout added this to the 1.0 milestone Feb 7, 2019
@afshin afshin modified the milestones: 1.0, 1.1 Feb 28, 2019
@blink1073
Copy link
Member

We did this in #6938

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Sep 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

3 participants