New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No logout button #5966
Comments
Thanks for making the distinction. I think you're right. The current Quit button seems to call
/logout : https://github.com/jupyter/notebook/blob/cf1b7b36284dfff8ae55004d9e64789f79e842b5/notebook/notebookapp.py#L298
|
Some more references about the login button in classic notebook: Here is the html fragment for it: https://github.com/jupyter/notebook/blob/46a887f6e0ecf50f3af5ecadaa05a6ac34675fbb/notebook/templates/page.html#L137-L147 Here is a related template for logged out users? https://github.com/jupyter/notebook/blob/b8b66332e2023e83d2ee04f83d8814f567e01a4e/notebook/templates/logout.html Here is a reference in the main.js: https://github.com/jupyter/notebook/blob/b8b66332e2023e83d2ee04f83d8814f567e01a4e/notebook/static/terminal/js/main.js#L32-L33 There are lots of references to 'login' or 'logout' in the notebook app: https://github.com/jupyter/notebook/blob/cf1b7b36284dfff8ae55004d9e64789f79e842b5/notebook/notebookapp.py |
Do I understand right that "logout" will come in 1.0.x? What would be the timeline for the release? |
I put it as a 1.0 issue since it is a backwards compatibility concern. We don't have a specific timeline. I imagine "soon" (order of weeks/month/two months?), and the issue/PR queue is here: https://github.com/jupyterlab/jupyterlab/milestone/2 |
I'd like to work on this. |
Ping @zgqallen - Would you like to take a shot at merging jupyterlab-logout into jupyterlab itself ? |
@zgqallen, I'm picking this up, you can ping here if you feel like you want to try contributing. |
Hello @vykozlov, all, |
It is sort of re-opening of "No logout button #4414", because there is no "Logout" button:
ver. 0.35.4, installed as pip install jupyterlab in Docker container.
#5226 introduced the "Quit" button, i.e. to shutdown jupyterlab, but what is asked in #4414 and here, is "Logout" button.
It would be really nice to have it in the jupyterlab core.
The text was updated successfully, but these errors were encountered: