Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No logout button #5966

Closed
vykozlov opened this issue Feb 8, 2019 · 8 comments · Fixed by #6087
Closed

No logout button #5966

vykozlov opened this issue Feb 8, 2019 · 8 comments · Fixed by #6087
Labels
good first issue pkg:application status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Feature Parity
Milestone

Comments

@vykozlov
Copy link

vykozlov commented Feb 8, 2019

It is sort of re-opening of "No logout button #4414", because there is no "Logout" button:

ver. 0.35.4, installed as pip install jupyterlab in Docker container.

#5226 introduced the "Quit" button, i.e. to shutdown jupyterlab, but what is asked in #4414 and here, is "Logout" button.

It would be really nice to have it in the jupyterlab core.

@jasongrout
Copy link
Contributor

jasongrout commented Feb 8, 2019

Thanks for making the distinction. I think you're right. The current Quit button seems to call /api/shutdown:

let apiURL = URLExt.join(setting.baseUrl, 'api/shutdown');
https://github.com/jupyter/notebook/blob/cf1b7b36284dfff8ae55004d9e64789f79e842b5/notebook/notebookapp.py#L314 , but the logout button called /logout: https://github.com/jupyter/notebook/blob/cf1b7b36284dfff8ae55004d9e64789f79e842b5/notebook/notebookapp.py#L298

@jasongrout jasongrout added this to the 1.0 milestone Feb 8, 2019
@jasongrout
Copy link
Contributor

@vykozlov
Copy link
Author

vykozlov commented Feb 8, 2019

Do I understand right that "logout" will come in 1.0.x? What would be the timeline for the release?

@jasongrout
Copy link
Contributor

I put it as a 1.0 issue since it is a backwards compatibility concern. We don't have a specific timeline. I imagine "soon" (order of weeks/month/two months?), and the issue/PR queue is here: https://github.com/jupyterlab/jupyterlab/milestone/2

@Madhu94
Copy link
Contributor

Madhu94 commented Mar 3, 2019

I'd like to work on this.

@Madhu94
Copy link
Contributor

Madhu94 commented Mar 4, 2019

Ping @zgqallen - Would you like to take a shot at merging jupyterlab-logout into jupyterlab itself ?

@Madhu94
Copy link
Contributor

Madhu94 commented Mar 9, 2019

@zgqallen, I'm picking this up, you can ping here if you feel like you want to try contributing.

@byouness
Copy link

byouness commented Mar 15, 2019

Hello @vykozlov, all,
Until this point is fixed, as a workaround, if your JupyterLab is running under ip:port/lab, open ip:port/tree and logout using the jupyter notebook Logout button.

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue pkg:application status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Feature Parity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants