Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter lab build error #6086

Closed
robmarkcole opened this issue Mar 10, 2019 · 9 comments
Closed

Jupyter lab build error #6086

robmarkcole opened this issue Mar 10, 2019 · 9 comments
Assignees
Labels
pkg:vega status:Needs Info status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@robmarkcole
Copy link

Describe the bug
Jupyter lab build always fails with:

ERROR in ./~/vega-lite/build/src/compile/scale/component.js
Module not found: Error: Can't resolve 'vega' in '/Users/robincole/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/build/src/compile/scale'
 @ ./~/vega-lite/build/src/compile/scale/component.js 1:0-31
 @ ./~/vega-lite/build/src/compile/scale/parse.js
 @ ./~/vega-lite/build/src/compile/model.js
 @ ./~/vega-lite/build/src/compile/facet.js
 @ ./~/vega-lite/build/src/compile/buildmodel.js
 @ ./~/vega-lite/build/src/compile/compile.js
 @ ./~/vega-lite/build/src/index.js
 @ ./~/vega-embed/build/src/embed.js
 @ ./~/@jupyterlab/vega3-extension/lib/index.js
 @ ./build/index.out.js
 @ multi whatwg-fetch ./build/index.out.js
@rowles
Copy link

rowles commented Mar 11, 2019

I am seeing this same issue. Vega had an issue a couple months ago that broke our JupyterLab builds. Could be related?

@javabrett
Copy link

Appears fixed in their master but still pending release at this time.

vega/vega-lite@1bf8cae

@javabrett
Copy link

javabrett commented Mar 11, 2019

Possibly regressed in vega/vega-lite@3f3637a so locking temporarily to < 3.0.0-rc14 might fix build, or wait on next rc.

@rowles
Copy link

rowles commented Mar 11, 2019

Hmm, the vega extension locks the vega-embed version. It looks like vega-embed is very generous on its dependencies and rc versions get put in the dependency tree. Not that ideal. Maybe an issue should be created somewhere in vega.

Edit: filed an issue on vega-embed

Alternatively the vega-extension could specify a vega-lite peer dependency version?

@francoislauger
Copy link

Same bug here I think, jupyter lab build stop here:

[LabBuildApp] > node /Users/USER/anaconda3/lib/python3.6/site-packages/jupyterlab/staging/yarn.js run build
yarn run v1.9.4
$ webpack
ModuleNotFoundError: Module not found: Error: Can't resolve 'vega' in '/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/build/src/compile/scale'
    at factory.create (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/webpack/lib/Compilation.js:535:10)
    at factory (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/webpack/lib/NormalModuleFactory.js:397:22)
    at resolver (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/webpack/lib/NormalModuleFactory.js:130:21)
    at asyncLib.parallel (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/webpack/lib/NormalModuleFactory.js:224:22)
    at /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/neo-async/async.js:2825:7
    at /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/neo-async/async.js:6886:13
    at normalResolver.resolve (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/webpack/lib/NormalModuleFactory.js:214:25)
    at doResolve (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:184:12)
    at hook.callAsync (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
    at _fn0 (eval at create (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:15:1)
    at resolver.doResolve (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:37:5)
    at hook.callAsync (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
    at _fn0 (eval at create (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:15:1)
    at hook.callAsync (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
    at _fn0 (eval at create (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:12:1)
    at resolver.doResolve (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:42:38)
    at hook.callAsync (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
    at _fn41 (eval at create (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:381:1)
    at resolver.doResolve (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/ModuleKindPlugin.js:23:37)
    at hook.callAsync (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
    at _fn0 (eval at create (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:15:1)
    at hook.callAsync (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
    at _fn0 (eval at create (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:15:1)
    at args (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/forEachBail.js:30:14)
    at hook.callAsync (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
    at _fn0 (eval at create (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:15:1)
    at resolver.doResolve (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:37:5)
    at hook.callAsync (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
    at _fn0 (eval at create (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), <anonymous>:15:1)
    at hook.callAsync (/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
resolve 'vega' in '/Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/build/src/compile/scale'
  Parsed request is a module
  using description file: /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/build/package.json (relative path: ./src/compile/scale)
    Field 'browser' doesn't contain a valid alias configuration
    resolve as module
      /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/build/src/compile/scale/node_modules doesn't exist or is not a directory
      /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/build/src/compile/node_modules doesn't exist or is not a directory
      /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/build/src/node_modules doesn't exist or is not a directory
      /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/build/node_modules doesn't exist or is not a directory
      /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/node_modules doesn't exist or is not a directory
      /Users/USER/anaconda3/share/jupyter/lab/node_modules doesn't exist or is not a directory
      /Users/USER/anaconda3/share/jupyter/node_modules doesn't exist or is not a directory
      /Users/USER/anaconda3/share/node_modules doesn't exist or is not a directory
      /Users/USER/anaconda3/node_modules doesn't exist or is not a directory
      /Users/USER/node_modules doesn't exist or is not a directory
      /Users/node_modules doesn't exist or is not a directory
      /node_modules doesn't exist or is not a directory
      looking for modules in /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/node_modules
        using description file: /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
      looking for modules in /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules
        using description file: /Users/USER/anaconda3/share/jupyter/lab/staging/package.json (relative path: ./node_modules)
          Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/package.json (relative path: ./node_modules/vega)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
          using description file: /Users/USER/anaconda3/share/jupyter/lab/staging/package.json (relative path: ./node_modules/vega)
            no extension
              Field 'browser' doesn't contain a valid alias configuration
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega doesn't exist
            .wasm
              Field 'browser' doesn't contain a valid alias configuration
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega doesn't exist
            .wasm
              Field 'browser' doesn't contain a valid alias configuration
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega.wasm doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega.wasm doesn't exist
            .mjs
              Field 'browser' doesn't contain a valid alias configuration
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega.mjs doesn't exist
            .js
              Field 'browser' doesn't contain a valid alias configuration
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega.js doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega.js doesn't exist
            .json
              Field 'browser' doesn't contain a valid alias configuration
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega.json doesn't exist
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega.json doesn't exist
            as directory
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega doesn't exist
            as directory
              /Users/USER/anaconda3/share/jupyter/lab/staging/node_modules/vega doesn't exist
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@collinwo
Copy link

collinwo commented Mar 12, 2019

Got the same error.... Beside waiting vega-lite new release, is there a better to fix the version of it in jupyterlab. It seem to be a bad idea that new version of vega-lite break jupyterlab without any protection in jupyterlab...

ModuleNotFoundError: Module not found: Error: Can't resolve 'vega' in '/opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/build/src/spec'
[11:14:31] [Building image] at factory.create (/opt/conda/share/jupyter/lab/staging/node_modules/webpack/lib/Compilation.js:535:10)
[11:14:31] [Building image] at factory (/opt/conda/share/jupyter/lab/staging/node_modules/webpack/lib/NormalModuleFactory.js:397:22)
[11:14:31] [Building image] at resolver (/opt/conda/share/jupyter/lab/staging/node_modules/webpack/lib/NormalModuleFactory.js:130:21)
[11:14:31] [Building image] at asyncLib.parallel (/opt/conda/share/jupyter/lab/staging/node_modules/webpack/lib/NormalModuleFactory.js:224:22)
[11:14:31] [Building image] at /opt/conda/share/jupyter/lab/staging/node_modules/neo-async/async.js:2825:7
[11:14:31] [Building image] at /opt/conda/share/jupyter/lab/staging/node_modules/neo-async/async.js:6886:13
[11:14:31] [Building image] at normalResolver.resolve (/opt/conda/share/jupyter/lab/staging/node_modules/webpack/lib/NormalModuleFactory.js:214:25)
[11:14:31] [Building image] at doResolve (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:184:12)
[11:14:31] [Building image] at hook.callAsync (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
[11:14:31] [Building image] at _fn0 (eval at create (/opt/conda/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), :15:1)
[11:14:31] [Building image] at resolver.doResolve (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:37:5)
[11:14:31] [Building image] at hook.callAsync (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
[11:14:31] [Building image] at _fn0 (eval at create (/opt/conda/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), :15:1)
[11:14:31] [Building image] at hook.callAsync (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
[11:14:31] [Building image] at _fn0 (eval at create (/opt/conda/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), :12:1)
[11:14:31] [Building image] at resolver.doResolve (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:42:38)
[11:14:31] [Building image] at hook.callAsync (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
[11:14:31] [Building image] at _fn41 (eval at create (/opt/conda/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), :381:1)
[11:14:31] [Building image] at resolver.doResolve (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/ModuleKindPlugin.js:23:37)
[11:14:31] [Building image] at hook.callAsync (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
[11:14:31] [Building image] at _fn0 (eval at create (/opt/conda/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), :15:1)
[11:14:31] [Building image] at hook.callAsync (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
[11:14:31] [Building image] at _fn0 (eval at create (/opt/conda/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), :15:1)
[11:14:31] [Building image] at args (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/forEachBail.js:30:14)
[11:14:31] [Building image] at hook.callAsync (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
[11:14:31] [Building image] at _fn0 (eval at create (/opt/conda/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), :15:1)
[11:14:31] [Building image] at resolver.doResolve (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/UnsafeCachePlugin.js:37:5)
[11:14:31] [Building image] at hook.callAsync (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
[11:14:31] [Building image] at _fn0 (eval at create (/opt/conda/share/jupyter/lab/staging/node_modules/tapable/lib/HookCodeFactory.js:32:10), :15:1)
[11:14:31] [Building image] at hook.callAsync (/opt/conda/share/jupyter/lab/staging/node_modules/enhanced-resolve/lib/Resolver.js:238:5)
[11:14:31] [Building image] resolve 'vega' in '/opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/build/src/spec'
[11:14:31] [Building image] Parsed request is a module
[11:14:31] [Building image] using description file: /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/build/package.json (relative path: ./src/spec)
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] resolve as module
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/build/src/spec/node_modules doesn't exist or is not a directory
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/build/src/node_modules doesn't exist or is not a directory
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/build/node_modules doesn't exist or is not a directory
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/node_modules doesn't exist or is not a directory
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/node_modules doesn't exist or is not a directory
[11:14:31] [Building image] /opt/conda/share/jupyter/node_modules doesn't exist or is not a directory
[11:14:31] [Building image] /opt/conda/share/node_modules doesn't exist or is not a directory
[11:14:31] [Building image] /opt/conda/node_modules doesn't exist or is not a directory
[11:14:31] [Building image] /opt/node_modules doesn't exist or is not a directory
[11:14:31] [Building image] /node_modules doesn't exist or is not a directory
[11:14:31] [Building image] looking for modules in /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/node_modules
[11:14:31] [Building image] using description file: /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/package.json (relative path: ./node_modules)
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] looking for modules in /opt/conda/share/jupyter/lab/staging/node_modules
[11:14:31] [Building image] using description file: /opt/conda/share/jupyter/lab/staging/package.json (relative path: ./node_modules)
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] using description file: /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/package.json (relative path: ./node_modules/vega)
[11:14:31] [Building image] no extension
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] using description file: /opt/conda/share/jupyter/lab/staging/package.json (relative path: ./node_modules/vega)
[11:14:31] [Building image] no extension
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega doesn't exist
[11:14:31] [Building image] .wasm
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega doesn't exist
[11:14:31] [Building image] .wasm
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega.wasm doesn't exist
[11:14:31] [Building image] .mjs
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega.wasm doesn't exist
[11:14:31] [Building image] .mjs
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega.mjs doesn't exist
[11:14:31] [Building image] .js
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega.mjs doesn't exist
[11:14:31] [Building image] .js
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega.js doesn't exist
[11:14:31] [Building image] .json
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega.js doesn't exist
[11:14:31] [Building image] .json
[11:14:31] [Building image] Field 'browser' doesn't contain a valid alias configuration
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega.json doesn't exist
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega.json doesn't exist
[11:14:31] [Building image] as directory
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega-lite/node_modules/vega doesn't exist
[11:14:31] [Building image] as directory
[11:14:31] [Building image] /opt/conda/share/jupyter/lab/staging/node_modules/vega doesn't exist
[11:14:31] [Building image] error Command failed with exit code 1.

@jasongrout
Copy link
Contributor

Is this fixed with the recent vega upgrade? #6294

@saulshanabrook
Copy link
Member

Yeah I cannot reproduce this on master or on the latest alpha release.

@blink1073 blink1073 modified the milestones: 1.0, 1.1 May 17, 2019
@blink1073 blink1073 modified the milestones: 1.1, 1.2 Aug 27, 2019
@jasongrout jasongrout modified the milestones: 1.2, 2.0 Oct 11, 2019
@jasongrout
Copy link
Contributor

Closing as resolved. Please post here if this is still an issue. Thanks @saulshanabrook for checking on this!

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:vega status:Needs Info status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

8 participants