Logout button cannot be hidden

[fcollonval]

Describe the enhancement

Hey, this is an enhancement.

I was looking at the Logout behaviour in the classical notebook because I was surprised by the PR #6087 not having a way to hide it as for the Shut down button. Actually, it will not appear in the menu if the server option quit_button is True. But this is not coherent with the classical notebook.

In the classical notebook, the Login/Logout buttons display depends on logged_in and login_available properties of AuthenticatedHandler.

https://github.com/jupyter/notebook/blob/9560e0cf4c3a3612f7e0f869035e7e3eeb5853a0/notebook/templates/page.html#L139-L145

https://github.com/jupyter/notebook/blob/9560e0cf4c3a3612f7e0f869035e7e3eeb5853a0/notebook/base/handlers.py#L174-L177

https://github.com/jupyter/notebook/blob/9560e0cf4c3a3612f7e0f869035e7e3eeb5853a0/notebook/base/handlers.py#L184-L194

Those parameters are passed to the jinja template as parameters.

Basically if the user equals "anonymous", those buttons should be hidden. This can be obtain by customizing the login handler class.

Now the question is how to apply a similar behaviour in JupyterLab. I presume the main point is to figure out how to send the information to the frontend through the page_config_data as for the Shut down button.

jupyterlab/jupyterlab/labapp.py

Line 382 in 0af6067

settings['page_config_data']['quitButton'] = getattr(self, 'quit_button', False)

[blink1073]

Yep, that sounds right.

[blink1073]

Note: this would require changes to jupyterlab_server to add handling of parameters passed as page_config, as well as changes to jupyterlab to separate handling of shutdown from logout using this new page config.

jupyterlab/packages/mainmenu-extension/src/index.ts

Line 146 in f0153e0

const quitButton = PageConfig.getOption('quitButton').toLowerCase();

[jtpio]

@fcollonval probably this could be closed since the menu items can now be customized via the settings system?

[fcollonval]

I would not close it as the logout button should be conditioned on server settings.