Ctrl-W on windows closes browser window, not JupyterLab tab

[ivanov]

Describe the bug
Accel-W is meant to close a JupyterLab tab, and on Windows Accel maps to Ctrl.

Screenshots

Desktop (please complete the following information):

• OS: Windows 10
• Browsers: Chrome 74.0.3729.131, Firefox 66.0.5
• JupyterLab master b58e1dd

We should do some subset of - providing an alternative keyboard shortcut on windows for closing JupyterLab tabs by default, and also at least not display the misleading ctrl-w shortcut on windows, since that will close the whole browser tab, not just a jupyterlab tab within that tab.

[ivanov]

in diagram-codesprint#6, @corvinb also identified that this is an issue for MacOS 10.14.4 for Chrome and Safari.

[jasongrout]

Looks like Accel W is a bad shortcut for closing a tab. Any suggestions for a better one?

[vidartf]

Alt + W ?

[jasongrout]

According to https://en.wikipedia.org/wiki/Table_of_keyboard_shortcuts, Alt+W seems available.

On my mac, Alt+W inputs the greek sigma: ∑

[jasongrout]

Let's make this a good first issue to change the keyboard shortcut to Alt+W, which seems like it may not do anything in a windows browser either.

Fixing this issue is changing Accel W to Alt W here:

jupyterlab/packages/application-extension/schema/main.json

Lines 16 to 20 in df62287

	{
	"command": "application:close",
	"keys": ["Accel W"],
	"selector": ".jp-Activity"
	},

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.