Cmd Shift combination not recognized on mac/firefox

[jasongrout]

From #6447 (comment):

I noticed that the redo event was never getting triggered on mac. After testing a lot of things, I realized that on mac/firefox, pressing command, shift, and a key was triggering a keydown event with shiftKey set to false.

To test, I use the \ key because I'm pretty sure it is not assigned to anything, so there wouldn't be conflicts. I did try it with several other keys with the same results. You can go to a blank page, open the console, and do document.addEventListener('keydown', console.log); in the console and then press, say Command Shift \. You can notice that the console says it has a Meta Shift keyboard event, but the shiftKey attribute of the event is false. You can also see this by going to http://nonan.jp/keyevent/input.html and pressing the Command Shift \ combination and note that shiftKey is set correctly for the meta keydown event, but it is false for \ keydown event. In fact, on that website, I'm seeing correct shiftKey reporting for a keydown event for shift and \ and any combination of control, alt, and command (e.g., Command Alt Shift \, Command Ctrl Shift \, Alt Shift \, etc.) except Command Shift \.

I also tested firefox on windows, and it correctly reported the shiftKey status (though there Command is mapped to the OS modifier on the above test page, and presumably in the event).

The end result is that the Command Shift Z shortcut doesn't work for me on firefox on mac, but does on Chrome on mac. But this looks like a firefox bug, not a JLab bug.

So:

• Can someone reproduce this (firefox/mac)?
• If so, let's audit the keyboard shortcuts for Accel Shift <key> to make sure they work, or change them so they do work on mac/firefox, or decide it's not important enough to accommodate a firefox/mac bug.

[jasongrout]

Here are the commands I see that have Accel Shift in their shortcuts:

Shortcut	Command	Selector
Accel Shift D	application:toggle-mode	body
Accel Shift C	apputils:activate-command-palette	body
Accel Shift S	docmanager:save-as	body
Accel Shift G	documentsearch:highlightPrevious	.jp-mod-searchable
Accel Shift Z	editmenu:redo	[data-jp-undoer]
Accel Shift L	filebrowser:create-main-launcher	body
Accel Shift F	filebrowser:toggle-main	body
Accel Shift '	tabsmenu:activate-previously-used-tab	body

[jasongrout]

@afshin and I tried to debug what was happening, since his mac worked. In the end, creating a new Firefox profile made things work for me again. I don't know what the problem was, but I'm closing this, and noting to self that if someone has a weird problem, creating a new profile is a way to get a clean state in firefox.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.