Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use css-loader to import default style #6542

Open
blink1073 opened this issue Jun 12, 2019 · 2 comments
Open

Use css-loader to import default style #6542

blink1073 opened this issue Jun 12, 2019 · 2 comments
Labels
maintenance
Milestone
Future

Comments

@blink1073
Copy link
Member

This will allow us to use @import url('~foolib') to import the default style of a package.

Relies on webpack-contrib/css-loader#683
@blink1073 blink1073 added this to the 1.1 milestone Jun 12, 2019
@blink1073 blink1073 mentioned this issue Jun 12, 2019
Closed
4 tasks
@blink1073
Copy link
Member Author

cf xtermjs/xterm.js#2221

@blink1073 blink1073 modified the milestones: 1.1, 1.2 Aug 27, 2019
@jasongrout jasongrout modified the milestones: 1.2, 2.0 Oct 11, 2019
@jasongrout jasongrout modified the milestones: 2.0, Future Dec 2, 2019
@blink1073
Copy link
Member Author

Nice! webpack-contrib/css-loader#1099

@jasongrout jasongrout mentioned this issue Nov 24, 2020
Closed
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Dec 1, 2020
@jasongrout
Update css-loader
5bcb42c 
We can update now that we are not relying on css-loader to do deduplication of css.

This addresses a main issue of jupyterlab#9364 and paves the way to addressing jupyterlab#6542
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Dec 1, 2020
@jasongrout
Update css-loader
e3f1dfc 
We can update now that we are not relying on css-loader to do deduplication of css.

This addresses a main issue of jupyterlab#9364 and paves the way to addressing jupyterlab#6542
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Dec 2, 2020
@jasongrout
Update css-loader
19a2c0a 
We can update now that we are not relying on css-loader to do deduplication of css.

This addresses a main issue of jupyterlab#9364 and paves the way to addressing jupyterlab#6542
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Dec 2, 2020
@jasongrout
Update css-loader
ad12fa7 
We can update now that we are not relying on css-loader to do deduplication of css.

This addresses a main issue of jupyterlab#9364 and paves the way to addressing jupyterlab#6542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@jasongrout @blink1073