Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command + W closes window instead of tab on macOS #6574

Closed
clapierre opened this issue Jun 14, 2019 · 3 comments
Closed

Command + W closes window instead of tab on macOS #6574

clapierre opened this issue Jun 14, 2019 · 3 comments
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Accessibility tag:Design and UX
Milestone

Comments

@clapierre
Copy link

clapierre commented Jun 14, 2019

From Web4All Hackathon diagram-codesprint#6
Describe the bug
The keyboard shortcut for File -> Close Tab is Command + W. Pressing Command + W on an open tab closes the browser window.

To Reproduce

  1. Open a notebook.
  2. Press Command + W.
  3. See browser window close.

Expected behavior
Either 1) do not advertise the keyboard shortcut or 2) close the tab and not the window.

Desktop (please complete the following information):

  • OS: macOS Mojave (10.14.4)
  • Browser Chrome 4.0.3729.131 and Safari 12.1 (14607.1.40.1.4)
  • JupyterLab 1.0.0a3
@vidartf
Copy link
Member

vidartf commented Jun 14, 2019

Since #6357 was fixed, is this also resolved?

@saulshanabrook
Copy link
Member

@vidartf Yes I believe that PR fixed this.

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Accessibility tag:Design and UX
Projects
None yet
Development

No branches or pull requests

4 participants