Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use inverted/white icons for selected item in Tabs/Settings Editor #6621

Closed
ellisonbg opened this issue Jun 18, 2019 · 1 comment · Fixed by #6664
Closed

Use inverted/white icons for selected item in Tabs/Settings Editor #6621

ellisonbg opened this issue Jun 18, 2019 · 1 comment · Fixed by #6664
Assignees
@ellisonbg
Labels
bug pkg:settingeditor pkg:tabmanager status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Milestone
1.0

Comments

@ellisonbg
Copy link
Contributor

In the file browser, selected items have a white/inverted icon:

Screen Shot 2019-06-18 at 1 15 15 PM

However, in the Tabs panel, we use the non-inverted icons:

Screen Shot 2019-06-18 at 1 14 24 PM

This results in low contrast. We should use the inverted/white icons for the selected item in the Tabs panel.
@ellisonbg ellisonbg added this to the 1.0 milestone Jun 18, 2019
@ellisonbg ellisonbg changed the title Use inverted/white icons for selected item in Tabs panel Use inverted/white icons for selected item in Tabs/Settings Editor Jun 18, 2019
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Jun 19, 2019
@jasongrout
use selected icons in tab manager when appropriate
c12a257 
Fixes jupyterlab#6621
@jasongrout jasongrout mentioned this issue Jun 19, 2019
Closed
@ellisonbg ellisonbg mentioned this issue Jun 20, 2019
Merged
@ellisonbg ellisonbg self-assigned this Jun 20, 2019
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ellisonbg ellisonbg

Labels
bug pkg:settingeditor pkg:tabmanager status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Milestone
1.0
2 participants
@ellisonbg @jasongrout