Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebook UX - Cell type selection button in notebook toolbar. #6638

Closed
tgeorgeux opened this issue Jun 19, 2019 · 4 comments
Closed

Notebook UX - Cell type selection button in notebook toolbar. #6638

tgeorgeux opened this issue Jun 19, 2019 · 4 comments
Assignees
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Milestone

Comments

@tgeorgeux
Copy link
Contributor

tgeorgeux commented Jun 19, 2019

Describe the bug
In the notebook toolbar, the cell selection drop down menu doesn't have the correct icons or positioning. The icon is rounded like a 'font awesome' icon instead of sharp like the material version we are using on the adjacent buttons in the toolbar. The position of the icon is also off

To Reproduce
Steps to reproduce the behavior:

  1. Open a notebook
  2. Look at the toolbar
  3. See errors

Expected behavior
We should have a single drop-down icon as shown here, that icon should be from the Material Filled icon set, and it should be centered vertically.
baseline_arrow_drop_down_black_18dp

Screenshots
See in the below screenshot, the position is 5top 3 bottom instead of 4 top 4 bottom.
Screen Shot 2019-06-19 at 7 51 39 AM

@tgeorgeux
Copy link
Contributor Author

This icon is also off-color in dark mode.
Screen Shot 2019-06-19 at 8 47 35 AM

@ellisonbg ellisonbg self-assigned this Jun 20, 2019
@ellisonbg
Copy link
Contributor

Will tackle after #6664

@jasongrout
Copy link
Contributor

Fixed by #6672

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Design and UX
Projects
None yet
Development

No branches or pull requests

3 participants