Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the terminal scrollbar does not scroll #6674

Closed
jasongrout opened this issue Jun 21, 2019 · 4 comments · Fixed by #6676
Closed

Clicking the terminal scrollbar does not scroll #6674

jasongrout opened this issue Jun 21, 2019 · 4 comments · Fixed by #6676
Labels
pkg:terminal status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Contributor

  1. Open a terminal
  2. Generate enough content so that the scrollbar appears
  3. Try to drag the scrollbar with the mouse

What happens: the scrollbar doesn't move, but you end up selecting the text you are dragging over.

What should happen: the scrollbar should be clickable and draggable

@jasongrout jasongrout added this to the 1.0 milestone Jun 21, 2019
@ian-r-rose
Copy link
Member

Unfortunately, it looks like the culprit is the screen-reader mode for xterm.js, though I don't know why that is. I don't see any issues about it on that repo.

I see a few options in the short-term:

  1. Live with the bad scrollbar behavior.
  2. Revert screen-reader mode.
  3. Expose screen-reader mode to the user as a setting, defaulting to false (maybe?)

I am leaning towards three, as it would fix the issue for most users, keep screen-reader mode for those who need it, and can be implemented quickly.

@ian-r-rose
Copy link
Member

cf. #6359

@jasongrout
Copy link
Contributor Author

+1 for 3 if we can implement it for 1.0, otherwise option 2.

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:terminal status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants