Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure only vega-embed version #6675

Closed
saulshanabrook opened this issue Jun 21, 2019 · 1 comment · Fixed by #6685
Closed

Ensure only vega-embed version #6675

saulshanabrook opened this issue Jun 21, 2019 · 1 comment · Fixed by #6685
Labels
pkg:vega status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
Future

Comments

@saulshanabrook
Copy link
Member

Currently (as of #6591) we depend on different versions of vega-embed in the vega 4 and vega 5 extensions. However, we should be able to use the latest version of vega-embed with both of those extensions.

I wasn't able to get this working, however, without webpack just including one version of vega-lite instead of both versions, for some reason.
@saulshanabrook saulshanabrook added this to the Future milestone Jun 21, 2019
This was referenced Jun 21, 2019
Merged
Merged
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
pkg:vega status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Prebuild vega utils and revert exporting CSS saulshanabrook/jupyterlab
2 participants
@jasongrout @saulshanabrook