Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't extract css #6684

Closed
jasongrout opened this issue Jun 21, 2019 · 1 comment · Fixed by #6685
Closed

Don't extract css #6684

jasongrout opened this issue Jun 21, 2019 · 1 comment · Fixed by #6685
Assignees
@saulshanabrook
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Milestone
1.0

Comments

@jasongrout
Copy link
Contributor

In #6591, we extracted the css to a separate file, but @blink1073 pointed out in the discussion following the merge that we can't do that because the webpack public path is dynamic at runtime.

@saulshanabrook is working on reverting the extraction of css.
@jasongrout jasongrout added this to the 1.0 milestone Jun 21, 2019
@saulshanabrook saulshanabrook self-assigned this Jun 21, 2019
@jasongrout jasongrout mentioned this issue Jun 21, 2019
Merged
@saulshanabrook saulshanabrook mentioned this issue Jun 21, 2019
Merged
@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related discussion.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
@jasongrout jasongrout added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@saulshanabrook saulshanabrook

Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Prebuild vega utils and revert exporting CSS saulshanabrook/jupyterlab
2 participants
@jasongrout @saulshanabrook