Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of linked packages #6738

Closed
blink1073 opened this issue Jun 29, 2019 · 2 comments · Fixed by #7728
Closed

Better handling of linked packages #6738

blink1073 opened this issue Jun 29, 2019 · 2 comments · Fixed by #7728
Assignees
@blink1073
Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Milestone
2.0

Comments

@blink1073
Copy link
Member

blink1073 commented Jun 29, 2019 •
edited

@SylvainCorlay reported this while working on the ipywidgets upgrade. I'm going to come up with a repro, but the general idea is:

  • make an extension that depends on a published library

  • check out that library locally

  • bump the version number

  • run jupyter labextension link

  • change directories back to the extension

  • run jupyter labextension link

At this point, jupyter lab complains that it cannot find a published version of the linked dependency.
@blink1073 blink1073 added this to the 1.1 milestone Jun 29, 2019
@vidartf
Copy link
Member

vidartf commented Jun 29, 2019

Does it matter if the extension in question has an npm/yarn link to the library set up?

@blink1073
Copy link
Member Author

We tried that, it didn't work

@blink1073 blink1073 modified the milestones: 1.1, 1.2 Aug 27, 2019
@jasongrout jasongrout modified the milestones: 1.2, 2.0 Oct 11, 2019
@blink1073 blink1073 modified the milestones: 2.0, 3.0 Dec 23, 2019
@blink1073 blink1073 modified the milestones: 3.0, 2.0 Jan 3, 2020
@blink1073 blink1073 mentioned this issue Jan 3, 2020
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@blink1073 blink1073

Labels
bug status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Projects
None yet
Milestone
2.0
Development

Successfully merging a pull request may close this issue.

Fix handling of linked extensions blink1073/jupyterlab
3 participants
@jasongrout @vidartf @blink1073