Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading HTML or Image file does not force download, opens file instead #6829

Closed
kevmk04 opened this issue Jul 15, 2019 · 5 comments
Closed
Labels
bug pkg:filebrowser status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@kevmk04
Copy link

kevmk04 commented Jul 15, 2019

Describe the bug
When attempting to download an html file (.html) or an image file (.png, .jpeg, etc) using the context menu ( + Download) from the file manager, the file is opened in a new tab by Chrome and not downloaded. I suspect that any file that Chrome can render will exhibit this behavior.

The behavior in Firefox is similar. Firefox will also try to open the file but unlike Chrome it prompts the user with the option to save or open the file. See screen shot below of the prompt Firefox presents to the user.

Previously reported in #6525 but is not resolved in version 1.0.2.

To Reproduce
Steps to reproduce the behavior (in Chrome):

  1. Create or upload any html or image file to the file browser
  2. Right click on the file and select Download
  3. See new tab open with file displayed

Expected behavior
The file downloads directly to the local machine.

Desktop Information:

  • OS: Windows 10
  • Browser: Chrome -- 75.0.3770.100 (Official Build) (64-bit)
    Firefox -- 68.0 (64-bit)
  • JupyterLab: 1.0.2

FireFox ScreenShot
60908191-82edc680-a238-11e9-8430-96772c4a6ba1

@ian-r-rose
Copy link
Member

It's possible that this will be fixed by #6686. We should revisit this once that fix is in.

@ian-r-rose
Copy link
Member

Thanks for the report @kevmk04

@jwclark
Copy link

jwclark commented Aug 7, 2019

When attempting to download .ipynb files I also see the raw json contents in a new tab in place of a download prompt.

@jasongrout
Copy link
Contributor

The bugfix is in 1.0.5 (out on pypi now, soon up on conda-forge). Can you check with 1.0.5?

@jasongrout jasongrout added this to the 1.0.5 milestone Aug 10, 2019
@kevmk04
Copy link
Author

kevmk04 commented Aug 10, 2019

1.0.5 appears to fix the issue! Nice work! I tried a few different file types and all are working properly.

@kevmk04 kevmk04 closed this as completed Aug 10, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Sep 9, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug pkg:filebrowser status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

4 participants