Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Single-cell find-replace-all #6888

Closed
austinmw opened this issue Jul 25, 2019 · 7 comments
Closed

[Feature Request] Single-cell find-replace-all #6888

austinmw opened this issue Jul 25, 2019 · 7 comments
Labels
pkg:documentsearch status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@austinmw
Copy link

From what I've been told there's currently no single-cell find-replace-all option. To do this I need to go to help->launch classic notebook. In the classic notebook, the cell find/replace command is 'F', which would be great to have in jupyterlab.

This would also be beneficial because, while full-page find/replace is slow on large notebooks, in many cases users are only interested in the cell they're working in.

@austinmw austinmw changed the title (Feature Request] Single-cell find-replace-all [Feature Request] Single-cell find-replace-all Jul 25, 2019
@jasongrout
Copy link
Contributor

I think it would be great to have the standard find and replace have a separate "scope" dropdown that lets you decide the scope of the search. For a notebook it could be "cell" or "document". For a map it could be "viewport" or "map". For a text file it could be "paragraph" or "document". For a markdown it might be even more intelligent like "section" or "document".

@jasongrout
Copy link
Contributor

And then have that scope be an argument to the command, so you could tie a keybinding to a specific scope.

@jasongrout jasongrout added this to the Future milestone Jul 25, 2019
@slsongge
Copy link

slsongge commented Apr 6, 2020

@austinbrian Hi! How do you implement this option(single-cell find-replace-all) now?

@austinmw
Copy link
Author

@slsongge I open jupyter notebook instead :(

@rdrussotto
Copy link

This feature already seems to exist, but only works in certain browsers/OSes. I have been running JupyterLab on a remote server and accessing it in Chrome on Windows for some time, and I can do this by typing ctrl+shift+R. This brings up a line in the top of the cell where you type what to search for, then what to replace it with, and it automatically replaces all instances in that cell only.

But when I access the same server using a Mac, this shortcut does not work, and the most logical alternative, command+shift+R, refreshes the entire browser window. If the shortcut exists it is being overridden by the browser shortcut. On Chrome on Mac for this server, there is no find and replace option that works at all, with find in the top menu grayed out, and on Safari I can use the global find and replace function but not the version for the single cell.

I've been relying on this shortcut for a while and I would like to see it working on a Mac. I am surprised that I cannot find descriptions of it anywhere in the documentation. Could it have been included in JupyterLab by accident, building on the underlying packages?

Also relevant issues: #2017, #8937. Maybe a separate issue should be created for this?

@jasongrout
Copy link
Contributor

Also relevant issues: #2017, #8937. Maybe a separate issue should be created for this?

Yes, please create a separate issue for the keyboard shortcut issue.

@jasongrout
Copy link
Contributor

Find and replace in a single cell is being tracked at #2017 - let's move discussion there.

@jasongrout jasongrout modified the milestones: Future, Reference Mar 17, 2021
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Sep 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pkg:documentsearch status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

4 participants