Double click of CTRL + F does not fallback to Chromium search bar

[RafalSkolasinski]

Describe the bug
Double click of CTRL + F does not fallback to Chromium search bar.

To Reproduce

1. Run jupyterlab with

docker run --rm -it -p 127.0.0.1:8888:8888 -e JUPYTER_ENABLE_LAB=yes jupyter/minimal-notebook:307ad2bb5fce

2. Go to the jupyterlab and open new notebook
3. With cursor in edit mode in a cell click CTRL+F twice.

Expected behavior
The browser's searchfield is the active one instead of jupyter lab built-in.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• Ubuntu 18.04
• Browser [e.g. chrome 69.0, firefox 62.0]
• JupyterLab [1.0.4] from jupyter/minimal-notebook:307ad2bb5fce docker image

[jasongrout]

This is expected behavior - Ctrl+F invokes the JupyterLab search, and repeated uses focus the JupyterLab search interface. Are you requesting this as a new feature?

[RafalSkolasinski]

I thought that two consecutive invokes of CTRL + F were suppose to fallback to browser's search bar (ref).

If that's not the case then indeed I would be requesting this as a new feature.

Or is there an option to just disable JupyterLab search bar?

[jasongrout]

That reference was before we had an integrated search in JupyterLab.

You can disable the JupyterLab search on Ctrl+F by disabling that keyboard shortcut. Follow steps 1 and 2 of #6830

Then Ctrl+F invokes the codemirror search just for the cell. And doing Ctrl+F twice invokes the browser search.

[jasongrout]

Tagging this as a feature request. Perhaps pressing Ctrl+F when the jlab search interface is focused should close the search and allow the browser search to appear? Or perhaps there should be an option for this?

[jasongrout]

CC @aschlaep

[RafalSkolasinski]

Perhaps pressing Ctrl+F when the jlab search interface is focused should close the search and allow the browser search to appear?

That sounds like a very good idea and goes along with what (some) people are used to.

[krassowski]

Allow the browser search to appear - yes
Close the custom search - not until the jumping/performance issues are fully solved, please!

Rationale: it would be too easy to incidentally press a key sequence leading to a freeze of the interface when using large notebooks. As it does not seem easy to solve the performance issues, I would argue for caution when switching on/off the custom search functionality.

Also in another thread is has been mentioned that if you click on the menu bar, the browser search will appear (a workaround for current builds rather than a solution).

[sixers]

Hijacking default browser keyboard shortcuts is extremely annoying, especially as common ones as search. There has to be a way to disable CodeMirror search. I can't even count how many times it made me pull my hair out.

Eventually, I was able to disable this in the browser itself (I'm using Firefox): https://superuser.com/a/1317514

Please add an option to disable shortcuts like this.