New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom apps to reuse build system #6989
Comments
Note that the goal is for a custom app to provide its own base-set of extensions, replacing the list from lab. Simply exposing the path is therefore probably not the best solution, since it requires the custom app to rely on the internal implementation details of the build system (layout of core package.json, which recently changed in a patch release, c.f. #6938). A more robust solution could be to have a Pros:
Cons:
|
I agree with have a CoreConfig object that is only accessible by subclassing (not cli). It limits our user API while allowing for this use case. |
And to be clear, #6938 was in a minor alpha release, not a patch release. |
Another point for custom apps: Currently the build system in Some questions:
|
I've recently been experimenting with creating a custom lab app (https://github/com/vidartf/phoila). Mostly, I found the system to be configurable (some bits more easily than others), but the one bit I ended up having to monkey patch was
_get_core_data
. This function supplies the core configuration of the build, but is an internal function that is impossible to configure (it uses a hard-coded local path).Would there be any disagreement to making this path configurable?
The text was updated successfully, but these errors were encountered: