Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary unescaping quotes in pageconfig #7023

Closed
jasongrout opened this issue Aug 15, 2019 · 1 comment
Closed

Unnecessary unescaping quotes in pageconfig #7023

jasongrout opened this issue Aug 15, 2019 · 1 comment
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@jasongrout
Copy link
Contributor

jasongrout commented Aug 15, 2019

I think that this is probably not needed anymore:

for (let key in configData) {
// Quote characters are escaped, unescape them.
configData[key] = String(configData[key])
.split(''')
.join('"');
}

If it isn't needed, then unescaping like this can corrupt data (for example, if an attribute really has that escape sequence in it, it gets transformed to a quote)

I think #7016 especially means it is not needed.

This code was added in #2213

@jasongrout jasongrout added this to the 1.1 milestone Aug 15, 2019
@jasongrout jasongrout changed the title Do not double unescape quotes Unnecessary unescaping quotes in pageconfig Aug 15, 2019
@blink1073
Copy link
Member

Fixed in #7061

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Sep 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

No branches or pull requests

2 participants