Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Switch Sidebar Side" context menu item doesn't work if you right click on the sidebar tab's icon #7224

Closed
telamonian opened this issue Sep 18, 2019 · 1 comment · Fixed by #7242
Closed

"Switch Sidebar Side" context menu item doesn't work if you right click on the sidebar tab's icon #7224

telamonian opened this issue Sep 18, 2019 · 1 comment · Fixed by #7242
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone
1.2

Comments

@telamonian
Copy link
Member

If you right click on a sidebar tab and then select "Switch Sidebar Side", it won't work if you happened have right clicked on the tab icon. I'm pretty sure this broke because the icon is now a svg child node, instead of just a background image.
@jasongrout
Copy link
Contributor

Yep, that was the problem. Fix coming up.

@jasongrout jasongrout modified the milestones: 1.2, 2.0 Sep 19, 2019
jasongrout added a commit to jasongrout/jupyterlab that referenced this issue Sep 19, 2019
@jasongrout
Fixes context menu hit test to deal with svg nodes.
63ad63f 
Fixes jupyterlab#7224
@jasongrout jasongrout mentioned this issue Sep 19, 2019
Merged
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Oct 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Milestone
1.2
Development

Successfully merging a pull request may close this issue.

Fixes context menu hit test to deal with svg nodes. jasongrout/jupyterlab
2 participants
@jasongrout @telamonian