Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility check for extensions not working #7241

Closed
jasongrout opened this issue Sep 19, 2019 · 0 comments · Fixed by #7723
Closed

Compatibility check for extensions not working #7241

jasongrout opened this issue Sep 19, 2019 · 0 comments · Fixed by #7723
Assignees
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Milestone

Comments

@jasongrout
Copy link
Contributor

jasongrout commented Sep 19, 2019

Description

It seems that the compatibility check for versions is not working, when it at least should give a warning.

Reproduce

conda create -n jlabversion notebook nodejs
conda activate jlabversion
pip install --pre jupyterlab==2.0.0a0

Now try installing the widgets extension.

jupyter labextension install @jupyter-widgets/jupyterlab-manager

I think because of the yarn resolutions, it no longer fails to install. This is good (in that we can test the widgets extension in an alpha version easily) and bad (there should be at least some warning that we are installing into a jlab where the versions conflict with what is requested).

Expected behavior

I think the version compatibility check should at least warn if we are installing into a jlab prerelease where the eventual non-prerelease would conflict, and it should error out and not let you install the incompatible extension if jlab is not a prerelease version.

In this case, I would expect a warning that the extension is not compatible with the eventual release, but we are letting you install anyway, and I would expect installing into 2.0 final release would fail.

Context

  • Operating System and version: macOS 10.14.6
  • Browser and version: N/A
  • JupyterLab version: 2.0.0a0
@jasongrout jasongrout added this to the 2.0 milestone Sep 19, 2019
@jasongrout jasongrout self-assigned this Dec 2, 2019
@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 6, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Build System
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant