Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToolbarButtons with icons and labels not rendered correctly #7265

Closed
mbektas opened this issue Sep 26, 2019 · 3 comments · Fixed by #7266
Closed

ToolbarButtons with icons and labels not rendered correctly #7265

mbektas opened this issue Sep 26, 2019 · 3 comments · Fixed by #7266
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Milestone

Comments

@mbektas
Copy link
Member

mbektas commented Sep 26, 2019

Description

If a ToolbarButton is created with label and icon then icon and label are shown as separate rows that are centered, instead of shown as single row (label after the icon) as before.

ToolbarButton

Reproduce

new ToolbarButton({
      iconClassName: 'jp-AddIcon',
      label: 'Add Timestamp',
     ...
});

It could be caused by changes in #7236

@jasongrout
Copy link
Contributor

CC @telamonian

What versions of js packages and jupyterlab do you have?

@jasongrout jasongrout added this to the 1.2 milestone Sep 26, 2019
@mbektas
Copy link
Member Author

mbektas commented Sep 26, 2019

In sync with master. Most ^2.0.0-alpha.0. Tested using mbektas@4171b71

@telamonian
Copy link
Member

@jasongrout @mbektasbbg #7266 fixes this. Some extra SVG-specific styling was getting added to icons in the case where icon handling falls back to the old "icons as CSS background images" behavior.

Not coincidentally, the SVG styling for toolbar icon labels is also broken, so I'll fix that too in the same PR

@lock lock bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Oct 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants